mbergen
commented
5 days ago The only blocking thing to me is the issue with the combined transfers with the roles. But i think there is no other option while keeping the current display, and it's preferable to align the meaning of roles across all wikis
Summary
Introduces a single TransferData module that combines the current PositionIcon/PositionName modules and also brings separation of roles and positions.
To be backwards compatible, display roleicons in case position is unset.
Would also make #5110 obsolete, as transfers with different roles aren't merged.
Issues:
[ ] On LoL and similar wikis, this will require transfer input to be split by role, thus any transfer that currently has players and staff or multiple different staff "positions" needs to be adjusted, since there is only a single role input per team in a transfer.
How did you test this change?