search

LironEr / cypress-mochawesome-reporter

Zero config Mochawesome reporter for Cypress with screenshots and videos
MIT License
158 stars 49 forks source link

Video is added on not executed tests #149

Closed irapths closed 1 year ago

irapths commented 1 year ago

Environment

- OS: All
- Node: 
- cypress-mochawesome-reporter: 3.5.0
- cypress:

What happened?

The video is added as Additional Test Context on not executed (SKEPped) tests.

Moreover, using the new option videoOnFailOnly (#141) and set it to true does not prevent videos to be added on SKIPped tests.

Config file

Default settings

OR

videoOnFailOnly: true

Relevant log output

No response

Anything else?

The addition of video as Additional Test Context on tests is a great feature.

But I think it should be added only on executed tests (PASSed or FAILed) and not on SKIPped. Additionaly the option videoOnFailOnly: true should add video only on FAILed tests and prevent the video to be added on all others.

joakim-sch commented 1 year ago

Hi @irapths ! Thank you for your feedback. Glad you enjoyed the video feature 😄 🎥 The logic is just looking at not passed tests when videoOnFailOnly: true so there is definitely logic for skipped tests missing... Should be an easy fix tho 😃

joakim-sch commented 1 year ago

I have created PR #150 that should fix the issue ✌🏼

LironEr commented 1 year ago

Fixed in v3.5.1 Thanks @joakim-sch and @irapths