Check for network, version, protocol compatibility during handshake - Closes#1137 - Githubissues

LiskArchive / lisk-elements

⚙️ Library for sending Lisk transactions from the client or server

https://lisk.io/

GNU General Public License v3.0

250 stars 64 forks source link

Check for network, version, protocol compatibility during handshake - Closes#1137 #1189

Closed ishantiw closed 5 years ago

ishantiw commented 5 years ago

Description

Add a field in P2P config to allow compatibility check functions to be inserted in the constructor. The checks will cover,

Network compatibility (nethash)
Version compatibility (version)
Protocol version compatibility (protocolVersion)

Review checklist

The PR resolves #1137
All new code is covered with unit tests
All new code was formatted with Prettier
Linting passes
Tests pass
Commit messages follow the commit guidelines
Documentation has been added/updated