So they need to be replaced with constants per above schema.
Although length check is missing in signatures property (in code)
for the reason: "it is to support unsigned tx as well where there is no signature". Thus we can just add this comment in schema, so we know why it's not added there.
Description
transactionSchema
This schema uses constants for
minLength
,maxLength
But in code, these are added as hard coded values
So they need to be replaced with constants per above schema.
Although
length
check is missing insignatures
property (in code) for the reason: "it is to support unsigned tx as well where there is no signature". Thus we can just add this comment in schema, so we know why it's not added there.Motivation
If tomorrow we need to change lengths for module/command names, it would have a global effect by changing one line.
Additional Information