Lissy93 / dashy

🚀 A self-hostable personal dashboard built for you. Includes status-checking, widgets, themes, icon packs, a UI editor and tons more!
https://dashy.to
MIT License
18.22k stars 1.38k forks source link

[FEATURE_REQUEST] Allow using different faviconApi for each items #196

Closed zephyros-dev closed 3 years ago

zephyros-dev commented 3 years ago

Is your feature request related to a problem? If so, please describe.

Some of my internet-facing site have basic-auth, so the faviconkit API cannot get the icon for them. For example:

appConfig:
  faviconApi: faviconkit
  statusCheck: true
  theme: Material
sections:
  - name: Media management
    items:
# This service has basic-auth
      - icon: favicon
        statusCheckAllowInsecure: true
        statusCheckUrl: http://radarr:7878
        title: Radarr
        url: https://radarr.{{ server_domain }}
# This service doesn't have basic-auth
      - icon: favicon
        title: Nextcloud
        url: https://nextcloud.{{ server_domain }}

Using faviconkit will not return a favicon for the site with basic-auth. image If I change the faviconApi to local, I'm not sure how it works, but the icon appears normally. However, other services without basic-auth doesn't have icons anymore. image

Describe the solution you'd like

Allow using different faviconApi for each items entry. Something like this:

appConfig:
  statusCheck: true
  theme: Material
sections:
  - name: Media management
    items:
# This service has basic-auth
      - icon: favicon
        faviconApi: local
        statusCheckAllowInsecure: true
        statusCheckUrl: http://radarr:7878
        title: Radarr
        url: https://radarr.{{ server_domain }}
# This service doesn't have basic-auth
      - icon: favicon
        faviconApi: faviconkit
        title: Nextcloud
        url: https://nextcloud.{{ server_domain }}

Priority

Low (Nice-to-have)

Is this something you would be keen to implement

No response

Lissy93 commented 3 years ago

Thanks for the suggestion, I can certainly implement this, should be a quick task. Will do it this weekend :)

Lissy93 commented 3 years ago

Hey @phongngthanh - This is implemented in b756e65 of #201 released in V 1.7.1.

You can now use a different favicon API for certain items, just set icon: favicon-[api], e.g. favicon-clearbit

Hope that helps :)

P.s if you're enjoying Dashy, pls consider staring the repo