[FEATURE_REQUEST] Allow setting a target of `_top` on items

Lissy93 / dashy

🚀 A self-hostable personal dashboard built for you. Includes status-checking, widgets, themes, icon packs, a UI editor and tons more!

https://dashy.to

MIT License

18.19k stars 1.37k forks source link

[FEATURE_REQUEST] Allow setting a target of `_top` on items #289

Closed mdcollins05 closed 3 years ago

mdcollins05 commented 3 years ago

Is your feature request related to a problem? If so, please describe.

I use a Firefox extension to set my Dashy page as my new tab page. In doing so, it uses an iframe to display the website. I'd like the links to open in the new tab, so I use the item target option of "sametab" but it doesn't break out of the iframe. This results in the URL bar being blank (which is a feature of the extension) while navigating to the item I've clicked on.

Describe the solution you'd like

Ideally, I'd be able to set a the target to _top. Additionally, setting a default would be awesome, as all my items would have the same setting on them.

Priority

Medium (Would be very useful)

Is this something you would be keen to implement

Maybe

liss-bot commented 3 years ago

Welcome to Dashy 👋 It's great to have you here, but unfortunately your ticket has been closed to prevent spam. Before reopening this issue, please ensure the following criteria are met.

Issues are sometimes closed when users:

Have only recently joined GitHub
Have not yet stared this repository
Have not previously interacted with the repo

Before you reopen this issue, please also ensure that:

You have checked that a similar issue does not already exist
You have checked the documentation for an existing solution
You have completed the relevant sections in the Issue template

Once you have verified the above standards are met, you may reopen this issue. Sorry for any inconvenience caused, I'm just a bot, and sometimes make mistakes 🤖

Lissy93 commented 3 years ago

Heya @mdcollins05, I've implemented this in #292 :)

You can now set target: top to use _top (as well as still newtab, sametab, parent, modal or workspace)
You can also set defaultOpeningMethod within appConfig to one of those options, which will be applied to all items that don't have the target specifically set

Hope that helps :)

liss-bot commented 3 years ago

Hello @mdcollins05! It looks like all or part of this issue has now been implemented :) If you're enjoying Dashy, please consider supporting the project- for ways to get involved, see Contributing 💖

I am a bot, and this is an automated message 🤖

mdcollins05 commented 3 years ago

Wow, that was quick! Thanks so much.

liss-bot commented 3 years ago

The fix for this issue has now been released in Dashy 1.9.0 ✨

If you haven't done so already, please update your instance to 1.9.0 or later. See Dashy 1.9.0 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.