Discord/GitHub account linking

LittleBigRefresh / Refresh

A second-generation custom server for LittleBigPlanet that focuses on quality of life features and improving user experience.

https://lbp.littlebigrefresh.com

GNU Affero General Public License v3.0

76 stars 25 forks source link

Discord/GitHub account linking #665

Open Beyley opened 2 months ago

Beyley commented 2 months ago

This PR implements the basic support for Discord/OAuth2 account linking.

This is another doozy of a PR, so I'll break down the changes which you can skip through.

Most changes in the RefreshTests.GameServer folder is just minor refactoring as I fixed some naming when I moved around some code to Refresh.Common.
There are a couple changes in RefreshTests.GameServer which refactor manual DataContext creation to a helper method which already existed but was just unused for one reason or another. This was spurred on from the fact that more fields were added to DataContext, and without this refactor these tests no longer compiled.

Beyley commented 2 months ago

while implementing GitHub OAuth integration, i noticed some deficiencies in the current structure of some bits, so I'm going to mark as draft until I resolve those.

Beyley commented 2 months ago

Ready for review again I didn't intend to include GitHub account linking in this PR initially, but the GitHub code became intertwined with the cleanup work, and it'd be a lot of work to separate, so I figured I'd include it here, since its fully functional.

Beyley commented 2 months ago

Overall, I can see the use for Discord OAuth, but I don't get having a GitHub integration at all. It would be helpful if you explained some use-cases for those so we can track all that.

main thing i wanted github auth for was the Molecule pin, which is when you get a job at media molecule, i wanted to write some code to bump the github API to get the list of GitHub contributors to the LittleBigRefresh org, and automatically give you this pin if you contribute to any of our projects while having your GH account linked

jvyden commented 1 month ago

@Beyley Are you still interested in working on this or do you want me to take this over? Haven't heard anything in a while...

Beyley commented 1 month ago

@Beyley Are you still interested in working on this or do you want me to take this over? Haven't heard anything in a while...

still interested in working on this, but motivation is all over the place right now, you're free to pick this branch up since idk when i'll have the energy to do so