LivacoNew / CrabFetch

Extremely fast, featureful and customizable command-line fetcher.
Apache License 2.0
21 stars 4 forks source link

Remove "config" Dependency #9

Closed LivacoNew closed 5 months ago

LivacoNew commented 7 months ago

The config crate is what I previously used for configuration up until this point. The problem is it's really really slow; image NOTE: Ignore the wrong hostname output, this is due to me also changing the way color placeholders are done in config files.

So, my solution is simple; remove it. I've written my own way for handling value defaults, as well as my own janky TOML parser. image

Some notes for this;

I'm not sure whether to merge this or not yet, if I do it will be after a bit more testing. If anyone does read my ramblings here and wants to run this PR to test it, please go ahead. I'll fast-forward it after I'm done here to catch it up to master so we won't miss out on anything while running this branch.

LivacoNew commented 5 months ago

Looking at this 2 months on, I'm not happy with how I've implemented this. I've still not got time to work on this, but will hopefully do within a week or so once college is over. Once I do, I'll likely reject this PR and make a new branch and just start over with this, as it's a terrible impl.

LivacoNew commented 5 months ago

Closing this, as this is not even going to come close to being merged. I'll simply redo this in a new local branch and only make an actual PR once I'm happy, like how you're meant to use git.