search

Living-with-machines / DeezyMatch

A Flexible Deep Learning Approach to Fuzzy String Matching
https://living-with-machines.github.io/DeezyMatch/
Other
134 stars 34 forks source link

candidateFinder outputs #47

Closed kasra-hosseini closed 4 years ago

kasra-hosseini commented 4 years ago

@fedenanni wrote:

the fact that we return the values of "dl_match" and "cosine_sim" even if we use for instance "faiss_dist" to rank i find a bit confusing. The example that mariona shared on slack for instance. Maybe we could have a dictionary that associates ranking_metric.lower() with the correct dictionary to fill, we fill only that one and so the others would be empty.

This way we avoid issues with the user - if they selected "faiss" we return the ordered dict only for faiss

kasra-hosseini commented 4 years ago

We decided to keep the functionality as is, but have a clear documentation.