LivingWithHippos / unchained-android

App to interact with real-debrid API
GNU General Public License v3.0
404 stars 50 forks source link

[BUG] Add Kodi (crash) #295

Closed f1vefour closed 1 year ago

f1vefour commented 1 year ago

Describe the bug When trying to add a Kodi host it crashes to the main screen, I already have one host and have previously had two which I could choose the default between the two but I can't add a new one. I have tried clearing data and even uninstalling and reinstalling.

To Reproduce Try to add Kodi host, crash.

Smartphone (please complete the following information):

Additional context

4.51.4-beta does not have this issue but 4.53.2-beta and later does, just checked.

Installing 4.51.4, adding the hosts, then updating to either of the two later versions it crashes when trying to switch between Kodi hosts

It seems you added the ability to click which Kodi host one wants to use which of course is not a feature in the older 4.51.4 as clicking either host does nothing but in the later two versions it crashes just like when trying to add a host.

LivingWithHippos commented 1 year ago

Thanks for the report, should be already fixed, will be available on the next release. If you use the github version you can get the fixed one from github actions

f1vefour commented 1 year ago

Just tried version 4.53.4-beta from GitHub actions and it's the exact same way unfortunately.

LivingWithHippos commented 1 year ago

https://github.com/LivingWithHippos/unchained-android/actions/runs/3830157402

This one? The latest github action?

f1vefour commented 1 year ago

Yes that is the one.

LivingWithHippos commented 1 year ago

Ah right that is from the main branch. The changes are in dev so I need to trigger another action at least

f1vefour commented 1 year ago

I looked at dev and didn't see a difference, are there unpushed changes?

LivingWithHippos commented 1 year ago

May be, I remember fixing it, it's simply a wrong casting to image button of a material button

LivingWithHippos commented 1 year ago

https://github.com/LivingWithHippos/unchained-android/actions/runs/3984418995

I re run the github action with the latest change this should work

f1vefour commented 1 year ago

It indeed worked, thank you for the speedy resolution. Closing the issue.