Follow-up Check - Githubissues

LoanDB / ronataswestoldturkic

CLDF dataset derived from 'West Old Turkic' by András Róna-Tas and Árpád Berta from 2011

https://www.harrassowitz-verlag.de/title_4002.ahtml

Creative Commons Attribution 4.0 International

0 stars 0 forks source link

Follow-up Check #3

Closed martino-vic closed 1 year ago

martino-vic commented 2 years ago

@LinguList I added you as a collaborator for a general follow-up check to see what's left to do to make this repository ready to add it to the lexibank community :)

LinguList commented 2 years ago

Nice repo, as far as I can tell. I would say this also merits a blog post, if you want, as it is a larger concept list. Specifically, I'd say we should try and do the following:

[x] add concept list in its entirety to concepticon (ideally in April, so we can include it into concepticon 2.7, which we want to release by the end of April)
[x] check the forms in EDICTOR using pyedictor
[x] change license to cc-by-4.0, since this is the license we recommend for lexibank
[x] add a description of the data and how it was digitized in NOTES.md (will be included in readme.md later)

LinguList commented 2 years ago

The metadata.json should be adjusted a bit (the year is missing in the CLDF dataset derived from X and Y's "PAPER SHORT TITLE" from YEAR)

martino-vic commented 2 years ago

Implemented all suggestions (changes can be viewed in the commits history), only pending thing is submitting the concept list to concepticon, where I have opened an issue.

I'm sorry about the late reply, hope there's still the chance to write a blog post or similar about this some day

LinguList commented 2 years ago

Yep, this can definitely be done!

martino-vic commented 1 year ago

Update: all suggestions in https://github.com/martino-vic/rtbwestoldturkic/issues/3#issuecomment-1079646083 have been implemented. Now working on the blog-post, which can be accessed at this non-public repository: https://github.com/calc-project/calc-project/issues/91#issuecomment-1285592122

martino-vic commented 1 year ago

@LinguList I went through the repo once more, fixing some issues that came up recently. I think there might still be two open issues:

20
I remember vaguely that there was something wrong with col "Loan" in forms.csv. Might be this is a precedence and we have to brainstorm what the best convention would be. As I've understood the col "Loan" is supposed to tell whether the word in question is a loanword or not. That's why I've manually tagged all historical stages of Hungarian (H, OH, EAH, LAH) as True, and for West Old Turkic I went manually through the source pdf and set the value to True where the West Old Turkic word itself was borrowed (usually from a Mongolic language)

Maybe you could have one final look at the repo and see what could be still improved, so it can be added to lexibank :)