search

Log4s / log4s

High-performance SLF4J wrapper for Scala.
Other
171 stars 25 forks source link

Fix bug in 2.11 macros. #5

Closed bryce-anderson closed 10 years ago

bryce-anderson commented 10 years ago

It was a single period that would turn turn the params list into a curried set of params. It works when no exception is present because there is then only one set of params.

Eg: 

logger.trace(new Exception())("foo") ==  logger.logger.trace("foo")(new scala.`package`.Exception())

instead of the desired

 logger.logger.trace("foo", new scala.`package`.Exception())

See Quasiquotes splicing docs for more details.

Added some 'it must compile' tests.

sarahgerweck commented 10 years ago

Thanks for taking a look at this! I'll push a new build tonight.

bryce-anderson commented 10 years ago

Thank you for the rapid response. We're looking forward to dumping scala-logging for log4s.

sarahgerweck commented 10 years ago

Happy to! I feel guilty for having left it broken for so long in the first place, so thanks again for the PR. :bow: