search

LoginRadius / go-saml

High Level API Implementation of SAML 2.0 (Currently Supported Identity Provider Implementation) Single Sign On
MIT License
12 stars 13 forks source link

Implement error interface in Reject struct and return error in idp.go #15

Open mayankagwl opened 3 years ago

mayankagwl commented 3 years ago

Currently from the idp.go, Reject struct is returning, we like to return the error from every function of idp.go containing the Reject property So Implement the error interface in the Reject struct and use error type in the return values of the function

mayankagwl commented 3 years ago

And LoginRadius is also giving swags to people who will be contributing, so please make sure to read our blog and submit your info to get free goodies.

https://www.loginradius.com/engineering/page/hacktoberfest2020

xenowits commented 3 years ago

@mayankagwl should i take up this issue??

mayankagwl commented 3 years ago

@xenowits Yes sure, Go ahead assigning to you

xenowits commented 3 years ago

Yeah thanks👍👍

SezalAgrawal commented 2 years ago

@mayankagwl Can I pick up this issue?

mayankagwl commented 2 years ago

@SezalAgrawal Yes Sure, Go ahead assigning to you

SezalAgrawal commented 2 years ago

Hey @mayankagwl I can see an open PR already regarding this https://github.com/LoginRadius/go-saml/pull/28. Is this issue still open?