search

LoginRadius / loginradius-react

LoginRadius React SDK
MIT License
5 stars 9 forks source link

Add unit test for reducer #11

Open bhavin-a opened 2 years ago

bhavin-a commented 2 years ago

Hi @mohammed786, I was going through the code and found that we don't have UT added for reducer. Not sure if we want that but I feel that since reducers contain important business logic, they should be tested well on the type of state they are returning.

Let me know your thoughts on this. Would be really happy to help there 🙂. Thanks!!

mohammed786 commented 2 years ago

Hi, @Bhavin789 Sure you can take this up, Thanks for pointing it out 👍

bhavin-a commented 2 years ago

Hi @mohammed786 , have raised a PR here

Let me know if I missed something. Thanks!

bhavin-a commented 2 years ago

Hi @mohammed786. Just wanted to know if we are considering this issue valid for hacktoberfest? Thanks!

bhavin-a commented 2 years ago

Hi @mohammed786. Are we considering this for hacktoberfest? Thanks!

bhavin-a commented 2 years ago

Hi @mohammed786, any updates on this? Thanks