LongSoft / UEFITool

UEFI firmware image viewer and editor
BSD 2-Clause "Simplified" License
4.47k stars 632 forks source link

Suggested minor GUID database changes #325

Closed mikebeaton closed 1 year ago

mikebeaton commented 1 year ago

Correct me if I'm wrong, but I believe these GUIDs have typos in the name:

2755590C-6F3C-42FA-9EA4-A3BA543CDA25,EfiDebuSupportProtocolGuid
534BA4FD-D74C-1E41-AA7D-BB551364FBAD,AppleDebuSupportDxe
54CE6010-2A6D-42AA-B1E2-FD97DE9C4DA8,AppleDebuSupportFireWireInit
911D584C-35F7-4955-BEF9-B452769DDC3A,DebuSupportDxe
9546E07C-2CBB-4C88-986C-CD341086F044,EfiDebuSupportPeriodicCallbackProtocolGuid
A62D933A-9293-4D9F-9A16-CE81994CC4F2,AppleDebuSupport

[EDIT: updated list from 3 with AppleDebuSupport typo to 6 with DebuSupport typo]

i.e. should be DebugSupport with a 'g'. The error (if it is one) was introduced in https://github.com/LongSoft/UEFITool/commit/0fb88ab76035df49fd7967f43e207b77c68ad363 .

I was also going to suggest adding:

662AD66E-F52D-47F6-A350-488DB9F8AF68,FirmwareUserInterface
6A504489-884E-4465-A02F-03B248CDEF1,UserInterfaceTheme

These are the FDF file GUIDs for those two drivers in the MacPro 144.0.0.0.0 firmware which I am currently looking at.

There is already a value BC468182-0C0B-D645-A8AC-FB5D81076AE8,UserInterfaceThemeDriver in guids.csv, but I am not sure how this relates to the user interface driver value I am suggesting above, since the existing GUID from the CSV file does not occur in the MacPro 144.0.0.0.0 firmware which I am looking at - the existing value was added at https://github.com/LongSoft/UEFITool/commit/d16c4380699522db3b43feaf2dfe57b0c97ba75a. (Not sure if this genuinely reflects a conflict, or if both should exist, but thought I should mention it.)

These are both commits by @vit9696, so pinging if that's okay!