Error during compilation

[malltinaa]

Hi I get the following error when compiling on Arduino Uno, what is the solution? Of course, the Serial_CAN_Arduino lib is also installed. My Arduino version 1.8.13

"C:\\Program Files\\Arduino\\hardware\\tools\\avr/bin/avr-g++" -c -g -Os -w -std=gnu++11 -fpermissive -fno-exceptions -ffunction-sections -fdata-sections -fno-threadsafe-statics -Wno-error=narrowing -MMD -flto -mmcu=atmega328p -DF_CPU=16000000L -DARDUINO=10813 -DARDUINO_AVR_UNO -DARDUINO_ARCH_AVR "-IC:\\Program Files\\Arduino\\hardware\\arduino\\avr\\cores\\arduino" "-IC:\\Program Files\\Arduino\\hardware\\arduino\\avr\\variants\\standard" "-IC:\\Users\\rr\\Documents\\Arduino\\libraries\\OBD_II_RF_Dev_Kit_Library" "-IC:\\Program Files\\Arduino\\hardware\\arduino\\avr\\libraries\\SoftwareSerial\\src" "-IC:\\Users\\rr\\Documents\\Arduino\\libraries\\Serial_CAN_Arduino\\src" "C:\\Users\\rr\\Documents\\Arduino\\libraries\\OBD_II_RF_Dev_Kit_Library\\OBD_II_RF.cpp" -o "C:\\Users\\rr\\AppData\\Local\\Temp\\arduino_build_130214\\libraries\\OBD_II_RF_Dev_Kit_Library\\OBD_II_RF.cpp.o"
C:\Users\rr\Documents\Arduino\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp: In member function 'void Serial_CAN::begin(int, int, long unsigned int)':
C:\Users\rr\Documents\Arduino\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp:11:16: error: 'class Stream' has no member named 'begin'
     canSerial->begin(baud);
                ^~~~~
C:\Users\rr\Documents\Arduino\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp: In member function 'unsigned char Serial_CAN::baudRate(unsigned char)':
C:\Users\rr\Documents\Arduino\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp:154:20: error: 'class Stream' has no member named 'begin'
         canSerial->begin(baud[i]);
                    ^~~~~
C:\Users\rr\Documents\Arduino\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp:170:16: error: 'class Stream' has no member named 'begin'
     canSerial->begin(baud[rate]);
                ^~~~~
C:\Users\rr\Documents\Arduino\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp: In member function 'unsigned char Serial_CAN::factorySetting()':
C:\Users\rr\Documents\Arduino\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp:321:20: error: 'class Stream' has no member named 'begin'
         canSerial->begin(baud[i]);
                    ^~~~~
C:\Users\rr\Documents\Arduino\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp:331:24: error: 'class Stream' has no member named 'begin'
             canSerial->begin(9600);
                        ^~~~~
Using library OBD_II_RF_Dev_Kit_Library in folder: C:\Users\rr\Documents\Arduino\libraries\OBD_II_RF_Dev_Kit_Library (legacy)
Using library SoftwareSerial at version 1.0 in folder: C:\Program Files\Arduino\hardware\arduino\avr\libraries\SoftwareSerial 
Using library Serial_CAN_Arduino at version 1.0.0 in folder: C:\Users\rr\Documents\Arduino\libraries\Serial_CAN_Arduino 
exit status 1
Error compiling for board Arduino Uno.

[malltinaa]

After about two weeks, I still haven't received an answer and the problem has not been solved. You can't just sell hardware and not have software support.

[edisontim]

Hello, if you're still looking for a solution to this issue, you have to static_cast the canSerial into a SoftwareSerial as such: `static_cast<SoftwareSerial>(canSerial)->begin(baud);`

[malltinaa]

Hello, if you're still looking for a solution to this issue, you have to static_cast the canSerial into a SoftwareSerial as such: `static_cast<SoftwareSerial>(canSerial)->begin(baud);`

Thanks for the advice I made the changes you said in the OBD_II_RF.cpp file.

#include <Serial_CAN_Module.h>
#include <SoftwareSerial.h>

SoftwareSerial *canSerial = NULL;

void Serial_CAN::begin(int can_tx, int can_rx, unsigned long baud)
{
    canSerial = new SoftwareSerial(can_tx, can_rx);
    static_cast<SoftwareSerial*>(canSerial)->begin(baud);
}

unsigned char Serial_CAN::send(unsigned long id, uchar ext, uchar rtrBit, uchar len, const uchar *buf)
{
    unsigned char dta[14] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0};

    dta[0] = id>>24;        // id3
    dta[1] = id>>16&0xff;   // id2
    dta[2] = id>>8&0xff;    // id1
    dta[3] = id&0xff;       // id0

    dta[4] = ext;
    dta[5] = rtrBit;

    for(int i=0; i<len; i++)
    {
        dta[6+i] = buf[i];
    }

    for(int i=0; i<14; i++)
    {
        canSerial->write(dta[i]);
    }
}

// 0: no data
// 1: get data
unsigned char Serial_CAN::recv(unsigned long *id, uchar *buf)
{
    if(canSerial->available())
    {
        unsigned long timer_s = millis();

        int len = 0;
        uchar dta[20];

        while(1)
        {
            while(canSerial->available())
            {
                dta[len++] = canSerial->read();
                if(len == 12)
                    break;

                if((millis()-timer_s) > 10)
                {
                    canSerial->flush();
                    return 0; // Reading 12 bytes should be faster than 10ms, abort if it takes longer, we loose the partial message in this case
                }
            }

            if(len == 12) // Just to be sure, must be 12 here
            {
                unsigned long __id = 0;

                for(int i=0; i<4; i++) // Store the id of the sender
                {
                    __id <<= 8;
                    __id += dta[i];
                }

                *id = __id;

                for(int i=0; i<8; i++) // Store the message in the buffer
                {
                    buf[i] = dta[i+4];
                }
                return 1;
            }

            if(millis()-timer_s > 10)
            {
                canSerial->flush();
                return 0;
            }
        }
    }

    return 0;
}

unsigned char Serial_CAN::cmdOk(char *cmd)
{

    unsigned long timer_s = millis();
    unsigned char len = 0;

    canSerial->println(cmd);
    while(1)
    {
        if(millis()-timer_s > 500)
        {
            return 0;
        }

        while(canSerial->available())
        {

            str_tmp[len++] = canSerial->read();
            timer_s = millis();
        }

        if(len >= 4 && str_tmp[len-1] == '\n' && str_tmp[len-2] == '\r' && str_tmp[len-3] == 'K' && str_tmp[len-4] == 'O')
        {
            clear();
            return 1;        
        }

    }
}

/*
value       01  02  03  04  05      06  07  08  09  10      11  12  13  14  15  16  17  18
rate(kb/s)  5   10  20  25  31.2    33  40  50  80  83.3    95  100 125 200 250 500 666 1000
*/
unsigned char Serial_CAN::canRate(unsigned char rate)
{
    enterSettingMode();
    if(rate < 10)
        sprintf(str_tmp, "AT+C=0%d\r\n", rate);
    else 
        sprintf(str_tmp, "AT+C=%d\r\n", rate);

    int ret = cmdOk(str_tmp);

    exitSettingMode();
    return ret;
}

/*
value           0       1       2       3       4
baud rate(b/s)  9600    19200   38400   57600   115200
*/

unsigned char Serial_CAN::baudRate(unsigned char rate)
{
    unsigned long baud[5] = {9600, 19200, 38400, 57600, 115200};
    int baudNow = 0;

    for(int i=0; i<5; i++)
    {
        static_cast<SoftwareSerial*>(canSerial)->begin(baud[i]);
        canSerial->print("+++");
        delay(100);

        if(cmdOk("AT\r\n"))
        {
            //Serial.print("SERIAL BAUD RATE IS: ");
            //Serial.println(baud[i]);
            baudNow = i;
            break;     
        }
    }

    sprintf(str_tmp, "AT+S=%d\r\n", rate);
    cmdOk(str_tmp);

    static_cast<SoftwareSerial*>(canSerial)->begin(baud[rate]);

    int ret = cmdOk("AT\r\n");

    if(ret)
    {
        //Serial.print("Serial baudrate set to ");
        //Serial.println(baud[rate]);
    }

    exitSettingMode();
    return ret;
}

void Serial_CAN::clear()
{
    unsigned long timer_s = millis();
    while(1)
    {
        if(millis()-timer_s > 50)return;
        while(canSerial->available())
        {
            canSerial->read();
            timer_s = millis();
        }
    }
}

unsigned char Serial_CAN::enterSettingMode()
{
    canSerial->print("+++");
    clear();
    return 1;
}

unsigned char Serial_CAN::exitSettingMode()
{
    clear();
    int ret = cmdOk((char*)"AT+Q\r\n");
    clear();
    return ret;
}

void make8zerochar(int n, char *str, unsigned long num)
{
    for(int i=0; i<n; i++)
    {
        str[n-1-i] = num%0x10;
        if(str[n-1-i]<10)str[n-1-i]+='0';
        else str[n-1-i] = str[n-1-i]-10+'A';
        num >>= 4;
    }
    str[n] = '\0';    
}

/*
+++                     Switch from Normal mode to Config mode
AT+S=[value]            Set serial baud rate
AT+C=[value]            Set CAN Bus baud rate
AT+M=[N][EXT][value]    Set mask,AT+M=[1][0][000003DF]
AT+F=[N][EXT][value]    Set filter,AT+F=[1][0][000003DF]
AT+Q                Switch to Normal Mode
*/
unsigned char Serial_CAN::setMask(unsigned long *dta)
{
    enterSettingMode();
    char __str[10];

    for(int i=0; i<2; i++)
    {
        make8zerochar(8, __str, dta[1+2*i]);
        //Serial.println(__str);
        sprintf(str_tmp, "AT+M=[%d][%d][", i, dta[2*i]);
        for(int i=0; i<8; i++)
        {
            str_tmp[12+i] = __str[i];
        }
        str_tmp[20] = ']';
        str_tmp[21] = '\r';
        str_tmp[22] = '\n';
        str_tmp[23] = '\0';

        //Serial.println(str_tmp);

        if(!cmdOk(str_tmp))
        {
            //Serial.print("mask fail - ");
            //Serial.println(i);
            exitSettingMode();
            return 0;
        }
        clear();
        delay(10);
        //
    }
    exitSettingMode();
    return 1;

}

unsigned char Serial_CAN::setFilt(unsigned long *dta)
{
    enterSettingMode();

    char __str[10];

    for(int i=0; i<6; i++)
    {
        make8zerochar(8, __str, dta[1+2*i]);
        //Serial.println(__str);
        sprintf(str_tmp, "AT+F=[%d][%d][", i, dta[2*i]);
        for(int i=0; i<8; i++)
        {
            str_tmp[12+i] = __str[i];
        }
        str_tmp[20] = ']';
        str_tmp[21] = '\r';
        str_tmp[22] = '\n';
        str_tmp[23] = '\0';

        //Serial.println(str_tmp);

        clear();
        if(!cmdOk(str_tmp))
        {
            //Serial.print("filt fail at - ");
            //Serial.println(i);
            exitSettingMode();
            return 0;
        }
        clear();
        delay(10);
        //
    }
    exitSettingMode();
    return 1;
}

/*
value           0       1       2       3       4
baud rate(b/s)  9600    19200   38400   57600   115200
*/
unsigned char Serial_CAN::factorySetting()
{
    // check baudrate
    unsigned long baud[5] = {9600, 19200, 38400, 57600, 115200};

    for(int i=0; i<5; i++)
    {
        static_cast<SoftwareSerial*>(canSerial)->begin(baud[i]);
        canSerial->print("+++");
        delay(100);

        if(cmdOk("AT\r\n"))
        {
            //Serial.print("SERIAL BAUD RATE IS: ");
            //Serial.println(baud[i]);
            baudRate(0);                // set serial baudrate to 9600
            //Serial.println("SET SERIAL BAUD RATE TO: 9600 OK");
            static_cast<SoftwareSerial*>(canSerial)->begin(9600);
            break;            
        }
    }

    if(canRate(CAN_RATE_500))
    {
        //Serial.println("SET CAN BUS BAUD RATE TO 500Kb/s OK");
    }
    else
    {
        //Serial.println("SET CAN BUS BAUD RATE TO 500Kb/s FAIL");
        return 0;
    }

    unsigned long mask[4] = {0, 0, 0, 0,};
    unsigned long filt[12] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,};

    if(setFilt(filt))
    {
        //Serial.println("FACTORY SETTING FILTS OK");
    }
    else 
    {
        //Serial.println("FACTORY SETTING FILTS FAIL");
        return 0;        
    }

    if(setMask(mask))
    {
        //Serial.println("FACTORY SETTING MASKS OK");
    }
    else
    {
        //Serial.println("FACTORY SETTING MASKS FAIL");
        return 0;
    }

    return 1;
}

void Serial_CAN::debugMode()
{
    /*
    while(Serial.available())
    {
        canSerial->write(Serial.read());
    }

    while(canSerial->available())
    {
        Serial.write(canSerial->read());
    }*/
}

// END FILE

Now at compile time I get the following error.

"C:\\Program Files\\Arduino\\hardware\\tools\\avr/bin/avr-gcc" -w -Os -g -flto -fuse-linker-plugin -Wl,--gc-sections -mmcu=atmega328p -o "C:\\Users\\rr\\AppData\\Local\\Temp\\arduino_build_296017/obd_demo.ino.elf" "C:\\Users\\rr\\AppData\\Local\\Temp\\arduino_build_296017\\sketch\\obd_demo.ino.cpp.o" "C:\\Users\\rr\\AppData\\Local\\Temp\\arduino_build_296017\\libraries\\OBD_II_RF_Dev_Kit_Library\\OBD_II_RF.cpp.o" "C:\\Users\\rr\\AppData\\Local\\Temp\\arduino_build_296017\\libraries\\SoftwareSerial\\SoftwareSerial.cpp.o" "C:\\Users\\rr\\AppData\\Local\\Temp\\arduino_build_296017\\libraries\\Serial_CAN_Arduino\\Serial_CAN_Module.cpp.o" "C:\\Users\\rr\\AppData\\Local\\Temp\\arduino_build_296017/core\\core.a" "-LC:\\Users\\rr\\AppData\\Local\\Temp\\arduino_build_296017" -lm
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\Serial_CAN_Arduino\Serial_CAN_Module.cpp.o (symbol from plugin): In function `Serial_CAN::begin(int, int, unsigned long)':
(.text+0x0): multiple definition of `Serial_CAN::begin(int, int, unsigned long)'
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp.o (symbol from plugin):(.text+0x0): first defined here
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\Serial_CAN_Arduino\Serial_CAN_Module.cpp.o (symbol from plugin): In function `Serial_CAN::begin(int, int, unsigned long)':
(.text+0x0): multiple definition of `Serial_CAN::send(unsigned long, unsigned char, unsigned char, unsigned char, unsigned char const*)'
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp.o (symbol from plugin):(.text+0x0): first defined here
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\Serial_CAN_Arduino\Serial_CAN_Module.cpp.o (symbol from plugin): In function `Serial_CAN::begin(int, int, unsigned long)':
(.text+0x0): multiple definition of `Serial_CAN::recv(unsigned long*, unsigned char*)'
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp.o (symbol from plugin):(.text+0x0): first defined here
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\Serial_CAN_Arduino\Serial_CAN_Module.cpp.o (symbol from plugin): In function `Serial_CAN::begin(int, int, unsigned long)':
(.text+0x0): multiple definition of `Serial_CAN::clear()'
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp.o (symbol from plugin):(.text+0x0): first defined here
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\Serial_CAN_Arduino\Serial_CAN_Module.cpp.o (symbol from plugin): In function `Serial_CAN::begin(int, int, unsigned long)':
(.text+0x0): multiple definition of `Serial_CAN::cmdOk(char*)'
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp.o (symbol from plugin):(.text+0x0): first defined here
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\Serial_CAN_Arduino\Serial_CAN_Module.cpp.o (symbol from plugin): In function `Serial_CAN::begin(int, int, unsigned long)':
(.text+0x0): multiple definition of `Serial_CAN::enterSettingMode()'
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp.o (symbol from plugin):(.text+0x0): first defined here
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\Serial_CAN_Arduino\Serial_CAN_Module.cpp.o (symbol from plugin): In function `Serial_CAN::begin(int, int, unsigned long)':
(.text+0x0): multiple definition of `Serial_CAN::exitSettingMode()'
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp.o (symbol from plugin):(.text+0x0): first defined here
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\Serial_CAN_Arduino\Serial_CAN_Module.cpp.o (symbol from plugin): In function `Serial_CAN::begin(int, int, unsigned long)':
(.text+0x0): multiple definition of `Serial_CAN::canRate(unsigned char)'
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp.o (symbol from plugin):(.text+0x0): first defined here
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\Serial_CAN_Arduino\Serial_CAN_Module.cpp.o (symbol from plugin): In function `Serial_CAN::begin(int, int, unsigned long)':
(.text+0x0): multiple definition of `Serial_CAN::baudRate(unsigned char)'
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp.o (symbol from plugin):(.text+0x0): first defined here
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\Serial_CAN_Arduino\Serial_CAN_Module.cpp.o (symbol from plugin): In function `Serial_CAN::begin(int, int, unsigned long)':
(.text+0x0): multiple definition of `make8zerochar(int, char*, unsigned long)'
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp.o (symbol from plugin):(.text+0x0): first defined here
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\Serial_CAN_Arduino\Serial_CAN_Module.cpp.o (symbol from plugin): In function `Serial_CAN::begin(int, int, unsigned long)':
(.text+0x0): multiple definition of `Serial_CAN::setMask(unsigned long*)'
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp.o (symbol from plugin):(.text+0x0): first defined here
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\Serial_CAN_Arduino\Serial_CAN_Module.cpp.o (symbol from plugin): In function `Serial_CAN::begin(int, int, unsigned long)':
(.text+0x0): multiple definition of `Serial_CAN::setFilt(unsigned long*)'
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp.o (symbol from plugin):(.text+0x0): first defined here
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\Serial_CAN_Arduino\Serial_CAN_Module.cpp.o (symbol from plugin): In function `Serial_CAN::begin(int, int, unsigned long)':
(.text+0x0): multiple definition of `Serial_CAN::factorySetting()'
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp.o (symbol from plugin):(.text+0x0): first defined here
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\Serial_CAN_Arduino\Serial_CAN_Module.cpp.o (symbol from plugin): In function `Serial_CAN::begin(int, int, unsigned long)':
(.text+0x0): multiple definition of `Serial_CAN::debugMode()'
C:\Users\rr\AppData\Local\Temp\arduino_build_296017\libraries\OBD_II_RF_Dev_Kit_Library\OBD_II_RF.cpp.o (symbol from plugin):(.text+0x0): first defined here
collect2.exe: error: ld returned 1 exit status
Using library OBD_II_RF_Dev_Kit_Library in folder: C:\Users\rr\Documents\Arduino\libraries\OBD_II_RF_Dev_Kit_Library (legacy)

Maybe @stephen1874 can help me.

[edisontim]

They don't seem to be very active 😊 This is an issue of multiple includes of a class in your main cpp file, you should remove the Serialcan.hpp include I believe

[Dominik99d14]

I have the same problem. Could you please fix this in the code?

[malltinaa]

They don't seem to be very active blush This is an issue of multiple includes of a class in your main cpp file, you should remove the Serialcan.hpp include I believe

The problem is not solved, it seems that because the Serial CAN Arduino library has been rewritten, other libraries like OBD II RF Dev Kit Library are not handled.

[Mrowka1]

in file OBD_II_RF.cpp change line #include <Serial_CAN_Module.h> to #include <OBD_II_RF.h>