search

Longi94 / JavaSteam

Java library that provides an interface to directly interact with Valve's Steam servers.
MIT License
96 stars 20 forks source link

Remove spongycastle #261

Closed LossyDragon closed 3 months ago

LossyDragon commented 6 months ago

Description

Songy Castle is old and hasn't been updated since 2017. There could be a risk for security issues using it, though I am no expert with the Castles to know how much integration is there just for a Cipher instance.

This was a legacy support Android API running lower than Honeycomb. Google has since renamed their BC package since(even though that is now deprecated too).

Using normal BouncyCastle for Android is recommended based on many discussions whille reseaching. Even android development has a support floor for API 21 (API 24 is starting to become the new floor too with some dependencies).

See: https://stackoverflow.com/a/66323575/13225929

This wiki page should be updated to reflect the current info from the main readme.

Checklist

Addtional:

LossyDragon commented 3 months ago

Closing, will think about keeping it, just strongly update code and documentation to prefer BC over SC.