search

LonnyGomes / vjs-video

An angular js directive for video.js
http://lonnygomes.github.io/vjs-video/
MIT License
75 stars 33 forks source link

videojs-contrib-ads has not seen a loadstart event 5 seconds. #75

Closed MZeeshanSiddique closed 7 years ago

MZeeshanSiddique commented 7 years ago

Reference to this issue https://github.com/googleads/videojs-ima/issues/424 that i fixed "videojs-contrib-ads has not seen a loadstart event 5 seconds."

Will you guys help me out, is that fixed is fine or i have to do something else.

Old Implementation old-implementation

New Implementation new-implementation

ghost commented 7 years ago

Hi @engr-mzs, would you like to submit a pull request for this? I can merge it into the next release.

MZeeshanSiddique commented 7 years ago

Hi @LonnyGomes , hope you are fine. yes i want to submit this change but exactly i don't know the procedure. this is my first time to submit that type of changes.

ghost commented 7 years ago

@MZeeshanSiddique for this repository, make your change (don't include the commented out code) in your copy of vjs-video then you can submit a merge request. Here is a guide to get you started.

MZeeshanSiddique commented 7 years ago

@LonnyGomes i submit a pull request and i made changes in app/scripts/directives/vjs.directive.js is that fine ? or i have to make changes in dist folder or not ?

ghost commented 7 years ago

@MZeeshanSiddique sorry, I was traveling. You did it correctly, I will update dist when I build the new release. I'll take a look at it today! Thanks for the contribution!