LonoCloud / lein-voom

Tool for generating artifacts versioned on the most recent git commit sha and commit time.
Eclipse Public License 2.0
97 stars 14 forks source link

Datetime format used in version string incompatible with RPM package names #39

Open waynr opened 10 years ago

waynr commented 10 years ago

Our internal packaging tool for puppet-server uses the Maven artifact version to indicate package versions.

We are considering the use of lein-voom to track internal development versions of puppet-server to avoid inconsistent jumps [edit: in version string, ie 0.2.1 to 0.2.5 to 0.2.7] between publicly-released maven artifacts and OS packages. However, my initial trials of lein voom have revealed that the datetime format used in its version strings is incompatible with RPM package naming conventions due to the use of understore in `YYYYMMDD_HHmm".

Two different approaches that we believe would address this issue include:

I am personally partial to the second approach. If this issue is approved by the core developer(s) I will research available clojure datetime string formatting libraries and submit a PR ASAP.

abrooks commented 10 years ago

I think your assessment in #40 is probably right though there might be some wiggle room, via the metadata. I'll think about it but won't promise anything. Version strings are forever and the primary compatability, communication point.

We have heard of issues with some artifact repositories not taking these strings as well even though, they are fully compliant with the Maven version spec and implementation.

I'm always happy to hear suggestions.