search

LoopPerfect / buckaroo

The decentralized package manager for C++ and friends 🏝️
https://buckaroo.pm
MIT License
933 stars 33 forks source link

use mailbox-processor for expensive git operations #260

Open nikhedonia opened 5 years ago

nikhedonia commented 5 years ago

Just noticed that we sometimes fetch the same resource twice in parallel. As a result we half our bandwith and things take twice as long.

Running bash git --no-pager -C /home/gaetano/.buckaroo/cache/https-github-com-buckaroo-pm-boost-math-git-715040a9224ed40c fetch origin master:master
Running bash git --no-pager -C /home/gaetano/.buckaroo/cache/https-github-com-buckaroo-pm-boost-math-git-715040a9224ed40c fetch origin master:master

Note: commands like git.hasCommit must not be cached

njlr commented 5 years ago

Does this belong in GitCli or does it belong in a wrapper for IGit?

nikhedonia commented 5 years ago

I think those operations need to be cached & sequenced regardless of the implementation. Maybe GitManager?