Lora-net / llcc68_driver

Driver for LLCC68 radio
BSD 3-Clause Clear License
59 stars 24 forks source link

sync word issue #4

Open yuechuan-maszen opened 7 months ago

yuechuan-maszen commented 7 months ago

Hi there, the sync word in the datasheet is described as "Set to 0x3444 for Public Network, Set to 0x1424 for Private Network". But in this driver implementation, it is setting 0x3X4X for Public Network, and setting 0x1X2X for Private Network, provided X is what already exist in the register address. For example, if I have 0x56 at LoRa Sync Word MSB and 0x78 at LoRa Sync Word LSB, and I pass 0x12 for sync_word to llcc68_set_lora_sync_word(), I will get 0x1628. Although the reset value for LoRa Sync Word MSB is 0x14 and for LoRa Sync Word LSB it's 0x24; which means if I reset the device, then call llcc68_set_lora_sync_word(), I will always get the correct value. But it's still strange that the implementation is done this way.

Could you explain why llcc68_set_lora_sync_word() is implemented this way? Thanks a lot.

Best Regards, Yuechuan Yang