Lord-Kamina / keybinder

Firefox add-on that allows deep customization of shortcuts. Based on Tim Taubert's "Customizable Shortcuts."
Mozilla Public License 2.0
34 stars 3 forks source link

"Updated" popup interferes with video, shows no controls... #25

Open LorenAmelang opened 7 years ago

LorenAmelang commented 7 years ago

Your "Keybinder has been updated" popup randomly imposes itself on top of full-screen video or whatever else I'm doing in Firefox. At least in my two systems that use it, Win 10 and Win 7, the window seems to expose no controls, no obvious way to dismiss it.

Could you please detect when Firefox is in full screen mode and not interfere with that main display? Or open the notice in a background tab or window? And please include conventional close controls!

Lord-Kamina commented 7 years ago

I cannot open it in a tab. I made it focus because it ended up unnoticed most of the time. As for closing it, it's a standard dialog; it should be closable just like any dialog. On Mac at least, it is.

Additionally, it can be closed with Control (Command on Mac) + W, which is the default shortcut used for closing a tab.

LorenAmelang commented 7 years ago

Gregorio,

Under Win 10 it seems to be an independent window that can be Alt+Tabbed to the back, but it displays no header, no top menu, no footer, no close or resize icons, only the content pane. People are learning to close popups by looking for an 'X' icon in some corner, or lately just outside some corner. Maybe you could draw an 'X' in the top right corner and respond by closing the window? Or at least write an explanation beside the 'X' telling people what will close it? Without risking closing out a long video in the middle...

Loren

| Loren Amelang | loren@pacific.net |

On Wednesday, December 21, 2016 at 7:13 PM, Gregorio Litenstein notifications@github.com wrote:

I cannot open it in a tab. I made it focus because it ended up unnoticed most of the time. As for closing it, it's a standard dialog; it should be closable just like any dialog. On Mac at least, it is.

Lord-Kamina commented 7 years ago

This is what it looks like in Mac, the red button being analog to the Windows “X”; I’m afraid I don’t really have more control over this window aside from what is shown inside it. (i.e, I cannot add or remove anything from that menubard). If Windows shows the window without any sort of controls, that may actually be a bug in Firefox. However, I’m afraid I won’t be able to test it until I’ve got a Windows machine around to try it.

Nonetheless, as I said, pressing control+w should close the window.

On December 22, 2016 at 01:25:47, LorenAmelang (notifications@github.com) wrote:

Gregorio,

Under Win 10 it seems to be an independent window that can be Alt+Tabbed to the back, but it displays no header, no top menu, no footer, no close or resize icons, only the content pane. People are learning to close popups by looking for an 'X' icon in some corner, or lately just outside some corner. Maybe you could draw an 'X' in the top right corner and respond by closing the window? Or at least write an explanation beside the 'X' telling people what will close it? Without risking closing out a long video in the middle...

Loren

| Loren Amelang | loren@pacific.net |

On Wednesday, December 21, 2016 at 7:13 PM, Gregorio Litenstein notifications@github.com wrote:

I cannot open it in a tab. I made it focus because it ended up unnoticed most of the time. As for closing it, it's a standard dialog; it should be closable just like any dialog. On Mac at least, it is.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Lord-Kamina/keybinder/issues/25#issuecomment-268715677, or mute the thread https://github.com/notifications/unsubscribe-auth/AGJfLCJOgHe-_zyTE_d3xQh3dn1WUHAhks5rKfvKgaJpZM4LTlWC .