LorittaBot / Loritta

💁 A multipurpose, multilanguage, customizable, modular, and very cute bot for Discord! ~Making your server more awesome~
https://loritta.website/
GNU Affero General Public License v3.0
669 stars 170 forks source link

[LorittaBot#2629] Fix Unsupported OS when running LorittaLauncher with MacOsX #2630

Closed Toscaro closed 1 year ago

Toscaro commented 1 year ago

Context:

Now adding MacOsX as supported OS for development the dart-sass:1.35.2 seems to run in Rosetta for M1 macs, but still works, tested on a M1 mac.

For a directly ARM chip support (instead using Rosetta for translating x64) might be a good idea in the future migrate to at least Dart Sass 1.49.11.

Before:

Before_fix

After:

Folder created

After_fix_folder_created

Bot running

After_fix_bot_running
Toscaro commented 1 year ago

@MrPowerGamerBR, I could not set you as a Reviewer, but could you please look at it?

MrPowerGamerBR commented 1 year ago

LGTM, the only reason I didn't add MacOS support was because I don't have a Mac to test it lmao