Closed dnk8n closed 3 years ago
@dnk8n Is it working right now? I got the same message
@ThomasCybulski I think the bug I reported is still a problem.
I'm also having same issue.
Same issue here, but not with Shopify.
Same issue, with NextJS app. update: swapped to https://github.com/LottieFiles/lottie-react easily - all fine
Please use the https://github.com/LottieFiles/lottie-react player on react apps @dnk8n @yashwp @cgousley . The issue with shopify is because the player is a web component and must be imported as a client-side module that runs only on the browser. I've updated the readme in the development branch with an example of implementing this in nextJS as well @b-insh .
Closing due to inactivity.
I followed Shopify tutorial, for links to full tutorial see https://github.com/Shopify/shopify-demo-app-node-react
I amended to use heroku (also free, instead of ngrok... see instructions below) so that the application could always be up even when I am away with laptop shutdown.
Instructions on what I did:
git clone git@gitlab.com:Shopify/shopify-demo-app-node-react.git
cd shopify-demo-app-node-react
Install Heroku CLI
heroku login
heroku create **lottie-player**
(might have to substitute 'lottie-player' for a unique name, also sub going forward with these instructions)heroku git:remote -a **lottie-player**
See https://dashboard.heroku.com/apps/**lottie-player**/settings (app URL can be found on this page, e.g. "Your app can be found at https://**lottie-player**.herokuapp.com/", remember to potentially sub in your app name for lottie-player)
The rest of the instructions are based on the official Shopify tutorial. No need to read the entire tutorial but it is recommended. What follows is a shortcut to get things up.
Get API keys from Shopify and add url above to Shopify, see https://github.com/Shopify/shopify-demo-app-node-react for Sopify tutorial links
As guided here, https://shopify.dev/tutorials/build-a-shopify-app-with-node-and-react/charge-a-fee-using-the-billing-api#set-up, add these environment variables
git push heroku master
Through Shopify, go to 'Test your app' (on first test you will get an opportunity to create a dev store)
You might have to make a test payment (don't worry, it doesn't bill you for real)
Validate the app is functional.
Make an edit to include lottie-web player, see commit - https://gitlab.com/dnk8n/shopify-demo-app-node-react/-/commit/ebb2904eaf5a73210806f63ad3edb68d939ac23e
First git add/commit then
git push heroku master
Again validate you can see your lottie-player based change (Currently this is not working)
An alternate that does work and is successfully deployed is - https://gitlab.com/dnk8n/shopify-demo-app-node-react/-/commit/85e436c7bcb3bac02242bc44ece50f3e2910ee81
This uses the react-lottie package
Question is, why would this work while the lottie-player implementation does not?
The debug log of failed deployment: