Closed jmfayard closed 5 years ago
There will be no clashes if we fix the issue I mentioned with other libraries being not resolved.
On Wed, Aug 28, 2019, 11:35 Louis CAD notifications@github.com wrote:
@LouisCAD commented on this pull request.
In buildSrc/src/main/kotlin/dependencies/Dependencies.kt https://github.com/LouisCAD/Splitties/pull/206#discussion_r318484542:
}
object KotlinX { val coroutines = Coroutines object Coroutines {
private const val version = "1.3.0"
private const val version = Versions.org_jetbrains_kotlinx
This will clash with other kotlinx libraries with different versions like serialization, immutable.collections, html, file-io… Can buildSrcVersions still share the version, using the artifact name prefix, or could it be a new feature?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LouisCAD/Splitties/pull/206?email_source=notifications&email_token=AADQFSAESSPLNKQBIGCKTLLQGZBFBA5CNFSM4IRAIN4KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCC5TTLY#pullrequestreview-280705455, or mute the thread https://github.com/notifications/unsubscribe-auth/AADQFSCAE3A5Q2FORBFRWV3QGZBFBANCNFSM4IRAIN4A .
Alright, subscribed to the two issues you linked. Will try locally with newer version once they are resolved.
Thanks for the PR and your plugin!
Issued reported here https://github.com/ben-manes/gradle-versions-plugin/issues/326
Regarding the issue when running ./gradlew dependencyUpdates
, you can see the build.gradle.kts
of the involved tests
module has some configuration (and is not a multiplatform module), but I see nothing that is improperly configured and should cause such a failure in that gradle task. Subscribed to the issue you linked too, thanks for adding the comment.
Hello Louis,
so here is a MVP of what would be possible to
$ ./gradle buildSrcVersions
to check for available updatesBasically only generate
Versions.kt
and use it insideDependencies.kt
That would completely work only once this is done
https://github.com/jmfayard/buildSrcVersions/issues/55 https://github.com/jmfayard/buildSrcVersions/pull/56
One thing I'm curious:
If you run
./gradlew dependencyUpdates
, you can see that lots of dependencies are missing inbuild/dependencyUpdates/report.json
and that a lot of warnings appearAny guess for why that's the case?