Typo: 'aperutre_ratio' in `AberrationsFactory` class

LouisDesdoigts / dLux

Differentiable optical models as parameterised neural networks in Jax using Zodiax

https://louisdesdoigts.github.io/dLux/

BSD 3-Clause "New" or "Revised" License

52 stars 6 forks source link

Closed LouisDesdoigts closed 1 year ago

LouisDesdoigts commented 1 year ago

Title

LouisDesdoigts commented 1 year ago

Also the __init__ docstring incorrectly shows all parameters as 'required'

LouisDesdoigts commented 1 year ago

also the name defaults to CircularAperture, it should default to ApplyBasisOPD or Aberrations

LouisDesdoigts commented 1 year ago

Done with PR #218