search

LouisLouis19 / pe

0 stars 0 forks source link

Position of return arrow #20

Open LouisLouis19 opened 2 years ago

LouisLouis19 commented 2 years ago

For self invocations like in step 7 and 11, shouldn't the dotted arrows be on the right hand side, instead of left? Screenshot 2021-11-12 at 5.27.17 PM.png

Shouldn't it be something like this? Screenshot 2021-11-12 at 5.31.43 PM.png

soc-se-bot commented 2 years ago

Team's Response

This issue has been rejected as it is still clear to the reader that the self-invocation has ended and has returned to the main function. The arrow was shifted to the left so that the words such as parseItemForAdding() could be read clearly below the starting arrow.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for the response! I believe that throughout your project you would want to make it look as if it is written by one person to adhere to the project quality standards. Although it is true that self-invocation might still be clear to some readers, it does not show any consistency in styling as the return arrows are placed on different sides. Therefore, the difference in styling formats, I believe, should be considered as a valid cosmetic issue which is a low severity documentation bug.