search

LoupVaillant / Monocypher

An easy to use, easy to deploy crypto library
https://monocypher.org
Other
580 stars 80 forks source link

Minor duplicative lines of code #201

Closed TomMD closed 3 years ago

TomMD commented 3 years ago

I see (well, something sees):

    u64 carry = 1;
    carry = 1;

Here: https://github.com/LoupVaillant/Monocypher/blob/01277b033c06c6dc4a67d0a15fb0a8a2b48f063a/src/monocypher.c#L1744

LoupVaillant commented 3 years ago

My, I must have been tired. Fixing right away, thanks.

TomMD commented 3 years ago

If you'd like you can run muse, and thus infer, on every PR. It will comment on such bugs.

LoupVaillant commented 3 years ago

This tool looks interesting indeed. I will take a look, thanks.

tankf33der commented 3 years ago

I confirm infer can warning this and gcc -fanalyzer cant.