Lovrom8 / RSMods

386 stars 34 forks source link

Rocksmith Crashing eventviewer stating its xinput1_3.dll RSmod #191

Closed mrcalland closed 22 hours ago

mrcalland commented 2 weeks ago

hi

I've been getting a lot of crashes on stream lately when using RSmod which by the way is an amazing mod and its essential for streaming with adding new songs etc.

In event viewer I'm seeing an error for xinput1_3.dll a lot when Rocksmith crashes mind its not the only thing mentioned I also get a graphics-hook32.dll crash from time to time with is from OBS.

I'm not sure what any of this means or whether it is all related to the mod.

here is the RSmod debug file from latest crash

RSMODS Version: 1.2.7.4 SRC. DEBUG: false. Wwise Logs: false. 1.53 [INFO] Running in Wine: false

MidiInWinMM::initialize: no MIDI input devices currently available.

1.62 [INFO] Starting MIDI 1.63 [INFO] (BUG PREVENTION) Prevented PnP Crash 1.63 [INFO] (BUG PREVENTION) Allowed Complex Uplay Passwords 1.63 [INFO] (BUG PREVENTION) Prevented Advanced Display Crash 1.63 [INFO] (BUG PREVENTION) Prevented Port Audio In Device Crash 1.63 [INFO] (BUG PREVENTION) Prevented Tone Bug 1.63 [INFO] RS_ASIO Bypass2RTC: false 1.63 [INFO] Allowed audio to be played in the background! 3.91 [INFO] ImGUI Init 30.03 [INFO] Crowd control server starting 30.03 [INFO] Trying to connect to crowd control 33.13 [ERROR] Unable to connect to crowd control

ffio1 commented 2 weeks ago

Don't click those links that were posted before. I think bots posted them.

ffio1 commented 2 weeks ago

When Rocksmith crashed, did it make a .mdmp file that it put into your Rocksmith folder? If so, can you share that.

mrcalland commented 2 weeks ago

it sure did yeah ive also got another one since sending the above

Rocksmith2014.zip

hope that worked

mrcalland commented 2 weeks ago

did you have any luck finding out why it was crashing?

mrcalland commented 1 week ago

decided to reinstall everything bit by bit it only seems to go wrong once the mod is installed

this is the mod using the graphics-hook32.dll

here is the error and its always at the end of a song when it crashes

Faulting application name: Rocksmith2014.exe, version: 0.0.0.0, time stamp: 0x63012822 Faulting module name: graphics-hook32.dll, version: 1.8.3.0, time stamp: 0xfb115737 Exception code: 0xc0000005 Fault offset: 0x000038eb Faulting process ID: 0x370c Faulting application start time: 0x01dafc9cf37cece4 Faulting application path: D:\SteamLibrary\steamapps\common\Rocksmith2014\Rocksmith2014.exe Faulting module path: C:\ProgramData\obs-studio-hook\graphics-hook32.dll Report ID: c779d7e5-9d06-4b1f-b728-146a7b0b8de6 Faulting package full name: Faulting package-relative application ID:

ffio1 commented 1 week ago

graphics-hook32.dll is not something we use, at least directly. That looks to be something OBS is using.

We only interface with the real xinput1_3.dll in your system folder (this is the file that lets you use xbox controllers on Windows, which we fake to get Rocksmith to run our code, then pass any calls to it back to the original), and then use some windows apis.

ffio1 commented 1 week ago

did you have any luck finding out why it was crashing?

I did not. I tried looking at both the crashes you attached, but my debug symbols didn't match up. I'm not sure why. Could you try reproducing this with these files. Put these in your Rocksmith2014 folder, and it should ask you to overwrite the xinput1_3.dll file. Say yes to that prompt. I don't believe this will fix your issue, but should make it easier for us to see where it's crashing. Resources.zip

mrcalland commented 1 week ago

will do will have to be tomorrow

mrcalland commented 1 week ago

graphics-hook32.dll is not something we use, at least directly. That looks to be something OBS is using.

We only interface with the real xinput1_3.dll in your system folder (this is the file that lets you use xbox controllers on Windows, which we fake to get Rocksmith to run our code, then pass any calls to it back to the original), and then use some windows apis.

I do use an Xbox controller its not plugged in but it as the drivers and such on the PC Microsoft GameInput installed could that be the issue

ffio1 commented 1 week ago

You shouldn't be impacted by the logic we use to pretend we are the Xbox controller interface. Those calls are direct passthrough, so the game asks us what state the xbox controller is in, then we ask the real xbox controller interface what the status is, then hand that back to the game.

We only do it to get Rocksmith to think we're a valid DLL and trust us to run our code.

mrcalland commented 1 week ago

I've done all sorts today to get this to happen but I'm only getting this graphic-hook issue which I've worked out is linked to scene switching using streamer.bot I've turned that off and its not doing it anymore. which is still annoying cos my whole stream setup is based on scene switching.

ill post the files as soon as that sort of input crash happens again.

mrcalland commented 1 week ago

hi it didn't take long

this is on start up of the game this time if it crash in game ill let you know

rocksmith crash file

crashfile.zip

RSmod debug log

RSMODS Version: 1.2.7.4 SRC. DEBUG: false. Wwise Logs: false. 1.55 [INFO] Running in Wine: false

MidiInWinMM::initialize: no MIDI input devices currently available.

1.71 [INFO] Starting MIDI 1.73 [INFO] (BUG PREVENTION) Prevented PnP Crash 1.73 [INFO] (BUG PREVENTION) Allowed Complex Uplay Passwords 1.73 [INFO] (BUG PREVENTION) Prevented Advanced Display Crash 1.73 [INFO] (BUG PREVENTION) Prevented Port Audio In Device Crash 1.73 [INFO] (BUG PREVENTION) Prevented Tone Bug 1.73 [INFO] RS_ASIO Bypass2RTC: false 1.73 [INFO] Allowed audio to be played in the background! 4.93 [INFO] ImGUI Init 30.04 [INFO] Crowd control server starting 30.04 [INFO] Trying to connect to crowd control 35.89 [ERROR] Unable to connect to crowd control

Event viewer Faulting application name: Rocksmith2014.exe, version: 0.0.0.0, time stamp: 0x63012822 Faulting module name: xinput1_3.dll, version: 0.0.0.0, time stamp: 0x66ce9145 Exception code: 0xc0000005 Fault offset: 0x000ab3b2 Faulting process ID: 0x3bd8 Faulting application start time: 0x01dafd4bc1571b63 Faulting application path: D:\SteamLibrary\steamapps\common\Rocksmith2014\Rocksmith2014.exe Faulting module path: D:\SteamLibrary\steamapps\common\Rocksmith2014\xinput1_3.dll Report ID: 75a369bc-0e86-4700-9db2-7f3eb823db0c Faulting package full name: Faulting package-relative application ID:

ffio1 commented 1 week ago

Thank you for that! That crash dump gave me some useful information as to where you were crashing. I have a couple potential fixes, Can you try these files and see if you're still crashing. If you are, can you share the new crash dump with me? Fix_Test1.zip

Additionally, if this logic is still crashing, I added a check to where we could potentially cut it off earlier in the chain. You could also try turning off the "Riff Repeater > 100% speed" mod with the above change, and that may also help if you are still crashing on this build.

mrcalland commented 1 week ago

so far so good mate, ill keep testing and any crash ill report in should i give it a good week testing?

as for RR 100% speed i have that unticked in RSmod never used it.

ffio1 commented 1 week ago

Yeah, give it a couple days to a week. Hopefully that should work for you, and if it does, I can submit the fix for others.

mrcalland commented 1 week ago

ok thank you so much hopefully that is going to sort it.

I did find out what the graphics-hook32.dll error was and that was to do with scene switching.

mrcalland commented 1 week ago

Well that didn't take long ha this time at the start of playing an official DLC

Rocksmith crash file

crashfile.zip

RSmod debug log

RSMODS Version: 1.2.7.4 SRC. DEBUG: false. Wwise Logs: false. 1.55 [INFO] Running in Wine: false

MidiInWinMM::initialize: no MIDI input devices currently available.

1.66 [INFO] Starting MIDI 1.67 [INFO] (BUG PREVENTION) Prevented PnP Crash 1.67 [INFO] (BUG PREVENTION) Allowed Complex Uplay Passwords 1.67 [INFO] (BUG PREVENTION) Prevented Advanced Display Crash 1.67 [INFO] (BUG PREVENTION) Prevented Port Audio In Device Crash 1.67 [INFO] (BUG PREVENTION) Prevented Tone Bug 1.67 [INFO] RS_ASIO Bypass2RTC: false 1.67 [INFO] Allowed audio to be played in the background! 3.66 [INFO] ImGUI Init 30.02 [INFO] Crowd control server starting 30.02 [INFO] Trying to connect to crowd control 32.05 [ERROR] Unable to connect to crowd control 1979.72 [ERROR] Invalid Pointer: IsExtendedRangeSong

Event Viewer Faulting application name: Rocksmith2014.exe, version: 0.0.0.0, time stamp: 0x63012822 Faulting module name: xinput1_3.dll, version: 0.0.0.0, time stamp: 0x66d5fb3c Exception code: 0xc0000005 Fault offset: 0x0003f656 Faulting process ID: 0x2204 Faulting application start time: 0x01dafe1393a32b02 Faulting application path: D:\SteamLibrary\steamapps\common\Rocksmith2014\Rocksmith2014.exe Faulting module path: D:\SteamLibrary\steamapps\common\Rocksmith2014\xinput1_3.dll Report ID: 1b3e1e6c-4ed0-4334-b0c9-e09f44073b0d Faulting package full name: Faulting package-relative application ID:

ffio1 commented 1 week ago

This is a different crash than the one before. Try this fix. I'm not sure its the proper solution but may fix the crash you're seeing.

Fix_Test2.zip

mrcalland commented 1 week ago

Ill let you know

ffio1 commented 5 days ago

Hey! Just checking in, have you been able to test this, and if so, have you had any crashes so far? No worries if not.

mrcalland commented 3 days ago

Hey! Just checking in, have you been able to test this, and if so, have you had any crashes so far? No worries if not.

hello yeah sorry well its been working great having rocksmith drop the tones in songs loads but i dont think its related but the last fix sorted the crashing on load up and after some songs

ffio1 commented 3 days ago

Great to hear! I'll try to get the fixes submitted.

mrcalland commented 2 days ago

That's awesome thanks for the help.

I've sent that file to noonydeloony as she was having the same issue crashing after songs and start up live on stream so I sent her the fix2 files and she never had an issue after

ffio1 commented 22 hours ago

Feel free to reopen / create a new issue if more crashes come up.