LuaLS / lua-language-server

A language server that offers Lua language support - programmed in Lua
https://luals.github.io
MIT License
3.29k stars 305 forks source link

Disable highlight of TODO/NOTE but keep semantic highlighting enabled #1809

Open dlukes opened 1 year ago

dlukes commented 1 year ago

Semantic highlighting unfortunately makes TODO/NOTE/etc. strings in comments unreadable with the color scheme I use (https://github.com/rebelot/kanagawa.nvim), but it can be useful otherwise. Is there a way to prevent semantic highlighting from altering the coloring of these TODO/NOTE strings in comments while keeping it enabled?

carsakiller commented 1 year ago

Can you provide a screenshot? I don't seem to get any highlighting for TODO/NOTE comments. image

EtiamNullam commented 1 year ago

@carsakiller: That's the problem: If sumneko-lsp is disabled then TODO has different highlight, making it easy to tell at a glance, otherwise it's overriden and looks like regular comment.

Check this comparison (above: LSP enabled, below: disabled):

comparison

Color of it obviously depends on your colorscheme.

You can see more details in the issue that I've submitted to a wrong language server: https://github.com/iamcco/diagnostic-languageserver/issues/86

carsakiller commented 1 year ago

I see, so this is a request then to add semantic tokens for TODO and NOTE

sumneko commented 1 year ago

I will try to reduce unnecessary semantic coloring for comments.