LuciaRolon / SotNRandomizerLauncher

Launcher for Castlevania: Symphony of the Night Randomizer!
GNU General Public License v3.0
5 stars 1 forks source link

Nymashock Fastcore Compatibility Core Swap Error #6

Closed Gods666thChild closed 1 month ago

Gods666thChild commented 1 month ago

Bizhawk DLL folder is potentially missing "nymafast-comp.wbx"

launcherfastcorecompatibilityerror

Gods666thChild commented 1 month ago

As soon as I submitted I feel I should clarify, "potentially" means I manually checked the DLL folder and the file was indeed not there. I just don't know if it was because of my numerous installs or if it is indeed missing this file in this version.

LuciaRolon commented 1 month ago

This issue is a result of the Compatibility Core not getting installed in the installation process.

public static void StoreCores(string currentAppDirectory, string targetDirectory)
        {
            string nymashockCorePath = Path.Combine(targetDirectory, "dll", "nymashock.wbx.zst");
            string nymafastCorePath = Path.Combine(targetDirectory, "dll", "nymafast.wbx");
            File.Copy(Path.Combine(currentAppDirectory, "baseFiles", "nymashock.wbx.zst"), nymashockCorePath, true);
            File.Copy(Path.Combine(currentAppDirectory, "baseFiles", "nymafast.wbx"), nymafastCorePath, true);
            SetAppConfig("CoreInstalled", "ClassicCore");
        }

It will be fixed in the next version. Is there any reason you're using the Compatibility Core? Or did you just find the error playing around with the Launcher? For now we've only found one user who needed it, but maybe there's more people impacted.

Gods666thChild commented 1 month ago

When testing using the Fastcore I was getting a ton of stutters and missed inputs. I noticed the option and read its description so I thought I'd try it out. I was able to get a copy of the file and it appears to have helped I believe. Still a stutter once in a while but not as bad as regular Fastcore.

Let me know if there is anything I can do to assist.

LuciaRolon commented 1 month ago

Solved in the latest version.