Lucreeper74 / Create-Metallurgy

Add-on for Create Mod, adding new metallurgy processings.
https://modrinth.com/mod/create-metallurgy
MIT License
7 stars 4 forks source link

[Enhancement 💡] Merge Metallurgy Advancement into Create Advancement for consistency with other Create mods. #12

Open ffuentesm opened 1 week ago

ffuentesm commented 1 week ago

I find it curious why Metallurgy has its own advancement tab when other create mods (Create Alloyed, Enchantment Industry, etc) have their mod progression into Create Advancement page.

image image image

I feel that the Metallurgic advancement tree could easily fit on the midpoint after acquiring the blaze burner. image

Lucreeper74 commented 1 week ago

Hey @ffuentesm! Yep, I had seen it but I forgot to think about it when I integrated the advancements. Let's say I did it the vanilla way without worrying about how Create did it. If its isn't that complex cause Create Enchantment Industry made a whole API to make Create more friendly to use for Addon developer and I don't want to use any API to just need to download Create Metallurgy and Create to play with it. So yea, that intresting new additions next update. Added to my todo list 👍 This will be close when I will added and commit it! Thanks to be active by propose enhancement on Github, that help me to improve Create Metallurgy.

ffuentesm commented 1 week ago

no problem, I am enjoying this mod a lot, especially with how similar it is to TiC, and I plan to use both on my mod list. So I want Metallurgic to be as friendly as possible with other mods from the get-go.

Just like how I add both Create and Immersive Engineering to all my mod lists, even if I do not go deep into any of them. Just the ability to create a tool that integrates with other features seamlessly. If things work well. I will use Metallurgic as my go-to Ore processing mod.

So I am waiting for the "ore integration" to use the Foundry to smelt all the ores. Like how people use Create for the Bulk Blasting.

Lucreeper74 commented 1 week ago

no problem, I am enjoying this mod a lot, especially with how similar it is to TiC, and I plan to use both on my mod list. So I want Metallurgic to be as friendly as possible with other mods from the get-go.

Just like how I add both Create and Immersive Engineering to all my mod lists, even if I do not go deep into any of them. Just the ability to create a tool that integrates with other features seamlessly. If things work well. I will use Metallurgic as my go-to Ore processing mod.

So I am waiting for the "ore integration" to use the Foundry to smelt all the ores. Like how people use Create for the Bulk Blasting.

That what I will aiming for the Futur of Create Metallurgy, you can check and debate on Discord in the Suggestion forum there is a pinned post that made for that here. Cause at the beginning, I was a bit lost on which direction to take.

Lucreeper74 commented 1 week ago

Hey @ffuentesm! I've got news! I know how to implement integrated Advancements to Create ones. I will add it when I go back to development.