search

LudovicRousseau / pyscard

pyscard smartcard library for python
http://pyscard.sourceforge.net/
GNU Lesser General Public License v2.1
403 stars 115 forks source link

Remove the Python 2.x-only Pyro dependency #186

Closed kurtmckee closed 2 months ago

kurtmckee commented 2 months ago

The Pyro dependency is Python 2.x only. This PR removes that dependency and the associated code. Note that there is no documentation for this feature, so nothing needed to be removed from the documentation.

coveralls commented 2 months ago

Coverage Status

coverage: 60.085% (+0.4%) from 59.711% when pulling 0b1cc8728cd65b6d0923004b3abdd22abaa41920 on kurtmckee:rm-pyro into 44de1652c3c60acb77a33db3d6b620783cc2e025 on LudovicRousseau:master.

LudovicRousseau commented 2 months ago

Pyro is Python 2 only, but Pyro4 and Pyro5 are available for Python 3.

I never used this code. So yes, it may be a good idea to remove it.

kurtmckee commented 2 months ago

I agree with you. All code carries a maintenance burden, so unused code is easy to consider removing. :+1:

LudovicRousseau commented 2 months ago

Thanks