search

LuisMayo / ace-attorney-discord-bot

Discord bot that turns comment chains into ace attorney scenes. Inspired by and using https://github.com/micah5/ace-attorney-reddit-bot
MIT License
64 stars 21 forks source link

Discord usernames that have characters like "𝔱π”₯𝔦𝔰" or "π“‰π’½π’Ύπ“ˆ" makes the bot not show a name at all. #34

Open essasetic opened 3 years ago

essasetic commented 3 years ago

Users that have special characters in their username ends up coming up as a blank where there should be a username.

My suggestion would be to have a fallback system where either the server username (if in normal characters) is used instead or to prompt the user to input what they would like their name to be (if the bot detects the use of special characters).

Screenshot from 2021-07-13 22-27-40

LuisMayo commented 3 years ago

I have been wanting to use the server username for a while now. The code is indeed ready in #5 . However, for it to work I need additional permissions from Discord which I requested to their support on March 25th. With no (human) response yet.

The other proposed solution may escalate badly. Imagine 5 out of 20 people in a conversation have weird names. Now we need to prompt this 5 people to input their names and then wait for them to answer before rendering.

It's weird

LuisMayo commented 3 years ago

That being said thanks a lot for your suggestions! ^^

essasetic commented 3 years ago

I have been wanting to use the server username for a while now. The code is indeed ready in #5 . However, for it to work I need additional permissions from Discord which I requested to their support on March 25th. With no (human) response yet.

Ah I see, well I'm glad a solution is there and ready for when discord approves it.

The other proposed solution may escalate badly. Imagine 5 out of 20 people in a conversation have weird names. Now we need to prompt this 5 people to input their names and then wait for them to answer before rendering.

Yeah that's a fair point that I hadn't considered. Still could possibly work fine enough on smaller servers though.

Despite this though, this project is still great and I've already generated a lot of funny interactions with my friends using it. So thanks for making this. :)

LuisMayo commented 2 years ago

This should be tracked on https://github.com/LuisMayo/objection_engine/issues/53