Add tests and assorted fixes and improvements

Lukasa / requests-ftp

An FTP transport adapter for use with the Python Requests library.

Other

68 stars 25 forks source link

Add tests and assorted fixes and improvements #11

Closed dashea closed 9 years ago

dashea commented 9 years ago

These patches, in brief, do the following:

Add a test suite (RETR and SIZE only, I didn't do anything with STOR or other commands)
Some changes to make the FTP adapter behave more like the HTTP-based adapters, so a ftp-ized requests Session can switch between http and ftp URLs more transparently
Add proxy support, because that's a thing somehow? If you do curl --proxy proxy ftp://... it'll do it as an http request, so this change just passes the request to HTTPAdapter
miscellaneous minor bug fixes

Lukasa commented 9 years ago

This is astonishing work, well done! I'm happy to merge it,with one note inline. Also, normally I'd rather use py.test instead of nose for tests: are you open to changing for this pull request?

dashea commented 9 years ago

Sure, I don't have any particular attachment to nose. I'll look into switching it to py.test tomorrow. A lazy first attempt (copying and pasting the setup.py chunk from the docs) resulted in no tests being run at all, and running py.test from the directory failed when it couldn't find requests_ftp. So I'm guessing something will have be to be lightly rearranged.

dashea commented 9 years ago

Changed the tests to py.test, moved "test" to "tests" so that it doesn't get picked up by setup.py sdist, and left setup.py alone as far the test target.

Lukasa commented 9 years ago

\o/ It's beautiful! :cake: :sparkles: