search

LukeSkywalker92 / TeleFrame

TeleFrame - a digital picture frame for telegram
MIT License
92 stars 28 forks source link

Implemented screen config commands init #97

Closed gegu closed 4 years ago

gegu commented 4 years ago

Dynamic initialization of commands for the screen.

gegu commented 4 years ago

The documentation errors was fixed.

what happens, if the screenSwitchOptions are left empty but the screen config requests it? We should somehow handle this error.

This must be handled by the implementer in screen.init. I've added the logger-object as additional argument init(options, logger).

The example has been extended to show how argument checking works.

Trenar commented 4 years ago

Nice, I like it. I think this is a very flexible implementation, even for future screen configurations.

Once this PR is merged, I'll adapt #94