search

LukeTillman / dse-docker

DataStax Enterprise running in a Docker Container
Apache License 2.0
47 stars 17 forks source link

adding healthchecks #11

Closed BlueHotDog closed 7 years ago

BlueHotDog commented 7 years ago

hey, this is the gist of it, some thing i'm not sure how to solve is the username/pass for cqlsh.. any idea?

LukeTillman commented 7 years ago

So, I'm pretty sure this image is installed with the defaults as far as authentication goes (i.e. the AllowAllAuthenticator in cassandra.yaml) which means we don't need credentials to connect. Since this image is meant for dev environments only, that's probably OK, although I'm willing to listen to arguments that it's not. If someone wants to enable authentication they'd currently have to be customizing the cassandra.yaml file to enable it, which means they're probably already doing a custom Dockerfile and build of their own to add the custom config (which also would give them an opportunity to override the HEALTHCHECK instruction and add credentials).

That said, I think there are two options:

  1. Just omit the -u and -p since the image doesn't ship with authentication on and leave overrides to users in their own builds if they want it.
  2. Add some environment variables to the Dockerfile (like HEALTHCHECK_USER and HEALTHCHECK_PASS) and then use those in the script only if they're set.

I tend to lean towards option 1 since that's the easiest.

LukeTillman commented 7 years ago

Closing this to archive this repository. Check out the new official Docker images from DataStax. Thanks!