LukeWasTakenn / luke_garages

Super lightweight FiveM resource that adds garages and impounds for the ESX Legacy framework
GNU General Public License v3.0
33 stars 37 forks source link

Support for society vehicles #68

Closed Esterze closed 2 years ago

Esterze commented 2 years ago

Hi,

I added some cars in the police society, so the players can use some cars, but when they get deleted they don't appear in the impound, probably because it's not supported. Is there anything I can do in order to show the police cars in the impound? If no, will you be adding support for it?

LukeWasTakenn commented 2 years ago

They are supported.

https://github.com/LukeWasTakenn/luke_garages/blob/e30a177a58698335be96fb5e3cbea271e9dc8d79/server/server.lua#L63

Are you deleting the vehicles by impounding them with the police job? Cause that is a currently open issue.

Esterze commented 2 years ago

No, I deleted the vehicle with /dv command. But I set the vehicle owner to "police", so I don't know if that would make any difference

On Tue, 8 Mar 2022, 14:49 Luke, @.***> wrote:

They are supported.

https://github.com/LukeWasTakenn/luke_garages/blob/e30a177a58698335be96fb5e3cbea271e9dc8d79/server/server.lua#L63

Are you deleting the vehicles by impounding them with the police job? Cause that is a currently open issue.

— Reply to this email directly, view it on GitHub https://github.com/LukeWasTakenn/luke_garages/issues/68#issuecomment-1061796763, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXHAGWQGUONBSOULXBIKPI3U65LGXANCNFSM5QGLOTUA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

LukeWasTakenn commented 2 years ago

Well yeah setting the owner to police where the query looks for player identifier won't work.

Someone PRed full support for society vehicles but they haven't updated the PR so I'll probably end up implementing this fully myself when I get to it.

Esterze commented 2 years ago

And can I know possibly when you could get to it? My server is near to being open to public, I just wanna know id it's gonna be this month.

On Tue, 8 Mar 2022, 15:05 Luke, @.***> wrote:

Well yeah setting the owner to police where the query looks for player identifier won't work.

Someone PRed full support for society vehicles but they haven't updated the PR so I'll probably end up implementing this fully myself when I get to it.

— Reply to this email directly, view it on GitHub https://github.com/LukeWasTakenn/luke_garages/issues/68#issuecomment-1061813467, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXHAGWUSB6SY5ZJTSJWTBHDU65NC5ANCNFSM5QGLOTUA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

LukeWasTakenn commented 2 years ago

Supported as of acdd493bf739a444a58e6d01184ecc66080681ae.

Need feedback on this.

Esterze commented 2 years ago

You'll get it, you're the best man.

On Sat, 12 Mar 2022, 14:11 Luke, @.***> wrote:

Closed #68 https://github.com/LukeWasTakenn/luke_garages/issues/68.

— Reply to this email directly, view it on GitHub https://github.com/LukeWasTakenn/luke_garages/issues/68#event-6229711898, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXHAGWUMT6MXNB6TTWP6KJTU7SJXTANCNFSM5QGLOTUA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>