search

Lullabot / drainpipe

GNU General Public License v3.0
34 stars 14 forks source link

Drainpipe does not support Github enterprise #739

Open tess-ten7 opened 6 days ago

tess-ten7 commented 6 days ago

In PantheonReviewApps.yml, the ./.github/actions/drainpipe/pantheon/review action calls out to https://api.github.com. This fails immediately on Github Enterprise instances which have a different URL. There is no way to customize the URL through a parameter either.

deviantintegral commented 6 days ago

This is self-hosted enterprise instances, or enterprise in the cloud? If it's the later, I bet there's some way we can automatically switch that. However, we have one client on enterprise cloud and I think we're calling api.github.com and it's wroking fine, so it's probably not needed.

For self hosted, we have no clients currently using it. I think we'd be glad to review a PR on this, but since we can't test it ourselves we'd need you or someone else with access to pick this one up.