LumiGuide / haskell-opencv

Haskell binding to OpenCV-3.x
Other
154 stars 44 forks source link

`matScalarCompare` has wrong result type #98

Closed achirkin closed 6 years ago

achirkin commented 7 years ago

https://github.com/LumiGuide/haskell-opencv/blob/4d668c7da81eeddf2275287ec21f1c51218463f0/opencv/src/OpenCV/Core/ArrayOps.hs#L343

As per OpenCV docs, cv::compare operation returns Word8 array - not the array of the same type as input; so I would suggest to put something like IO (Mat shape channels ('S Word8)) as the output type of this function.

roelvandijk commented 6 years ago

You are correct. Thank you!