Closed karl-lunarg closed 8 years ago
Fixed several bugs in vktrace related to mapping memory at non-zero offset and also vkGetPipelineCacheData. Now tracing of Dota+scaleform_vulkan no longer crashes but the replay isn't yet correct (mostly just a black window). Leave this bug open to track this replay issue.
Replay issue appears to be a regression in Source2 where it is mapping memory for vertex buffers and then not unmapping it (nor vkFlushMappedMemoryRanges) before the vkQueueSubmit that references the buffer that was mapped.
FYI Coherent mapped memory doesn't need unmap and vkFlushMappedMemoryRanges.
Yes vktrace will not work with apps that use coherent mapped memory (and don't put in extra uneeded UnmapMemory or FlushMappedMemoryRange). That has been a known issue for a while which we plan to address.
We have fixed some of coherent mapped memory issues in our private fork. Once getting stabilised, will try to push the changes upstream.
From Dan Ginsburg: