LunarG / gfxreconstruct

Graphics API Capture and Replay Tools for Reconstructing Graphics Application Behavior
https://vulkan.lunarg.com/doc/sdk/latest/linux/capture_tools.html
MIT License
410 stars 121 forks source link

Add frame number to messages received through debug utils #1859

Open bradgrantham-lunarg opened 2 hours ago

bradgrantham-lunarg commented 2 hours ago

This would allow a user of CDL to localize a crash to a short sequence of frames, make a trimmed recapture of those frames, and use that recapture to more quickly investigate bugs and make repro case. @jeremyg-lunarg

GFXR also may not be setting up debug utils messengers correctly, needs investigation as part of this task.

bradgrantham-lunarg commented 2 hours ago

@jeremyg-lunarg Is this most valuable in replay? Or does it have a place in capture as well?

jeremyg-lunarg commented 1 hour ago

@jeremyg-lunarg Is this most valuable in replay? Or does it have a place in capture as well?

For me it is mostly valuable for replay. But the values need to match the frame number settings for capture so that I can recapture to trim just the section that causes the error/crash.

jeremyg-lunarg commented 1 hour ago

This feature would be useful tracking down validation errors too.