search

Lusito / forget-me-not

Make the browser forget website data, except for the data you want to keep.
zlib License
226 stars 25 forks source link

Cookies are not being removed #73

Closed OhSoGood closed 5 years ago

OhSoGood commented 6 years ago

I let a comment on issue #59 , as I'm facing the same issue on two different computers, the second being brand new and having only a subset of extensions the other has (noscript, ublock origne, decentraleys, smartreferer). Anything than I can do to explore the problem?

Lusito commented 6 years ago

Hi, Sorry.. I've been on a business trip the past week. I will look into it as soon as possible.

OhSoGood commented 6 years ago

It seems I "solved" it but in a weird way. In the rules tab, I had the default behavior when no rules set to "Forget". I changed it to Block, closed Firefox and set it back to Forget, and now it works. Not very satisfactory from a developer point of view, but at least it did it. I let you decide if you wish to close the case. Anyway I'm so glad it works now! Thank you.

Lusito commented 6 years ago

Thanks for the information.. I haven't been able to find out the reason why this setting would affect this, but I'll add some reinforced checks to make sure settings don't contain invalid values to make sure this doesn't happen again.

Lusito commented 5 years ago

I can't currently check this, but I'm gonna make a good guess here, and say that it's probably a HSTS "supercookie", see also https://github.com/Lusito/forget-me-not/issues/27#issuecomment-394838472

Joel889 commented 5 years ago

The "cookie" is stored in http://kb.mozillazine.org/Webappsstore.sqlite

webappsstore.sqlite contains DOM Storage data. This data is set by web sites much in the same way as cookies.

Not sure if this can be cleaned by an extension. But the fact that Mozilla won't display it nor clean it when instructed is disappointing.

Lusito commented 5 years ago

dom storage = local storage. At least that's what it's supposed to be. Thus it should be removed if you configured FMN to remove local storage.

Can't really reproduce this issue on craigslist.

Joel889 commented 5 years ago

Try the following: 1) Go to: https://mdn.github.io/dom-examples/web-storage/index.html 2) Change the picture to the crocodile. 3) Perform "manual cleanup" using your addon. 4) Reusing the same tab, go to https://mdn.github.io/dom-examples/web-storage/index.html 5) The picture reverted back to Firefox (indicating that storage was cleaned successfully). 6) repeat steps 2, 3, 4. 7) The picture is still the crocodile.

The only way to clean storage for that site the second time, is to close the tab, open the same page again in a new tab, and then cleaning it.

I don't protect currently open domains when cleaning on demand. That's how I must have ended up with all this junk inside webappsstore.sqlite. I would clean on demand with several tabs open. I keep surfing inside those tabs, which means the entries that were just cleaned get re-created inside of webappsstore.sqlite. Eventually I'll close the tabs, but might never revisit the website, hence webappsstore.sqlite for those webpages will never get deleted.

Joel889 commented 5 years ago

Also, it appears the "cleaning on startup" isn't actually cleaning up webappsstore.sqlite. I tested this on a new Firefox profile, with just your extension installed.

1) "Clean on browser start" all boxes selected in your addon. 2) Go to: https://mdn.github.io/dom-examples/web-storage/index.html 3) Change the picture to the crocodile. 4) restart Firefox. 5) Go to: https://mdn.github.io/dom-examples/web-storage/index.html 6) Crocodile picture is showing.

Lusito commented 5 years ago

Thanks! I've identified the issue and a fix is on the way.

Joel889 commented 5 years ago

Do you know when the next version will come out?

Lusito commented 5 years ago

Since the current Version still needs some work and has a lot of rewritten code, that might not be perfect yet, I'm not gonna publish a new version before Christmas, as nobody wants lost cookies or similar during the holiday time.

I'm hoping for early January, but it depends on how much time I am able to spend. Sorry this version takes so long, but it really is quite a big rewrite of existing code.

OhSoGood commented 5 years ago

@Lusito : thank you so much for your time and your consciousness on forget-me-not. Keep up the track and bring us a nice new Year baby! Merry Chirstmas (of course)