LuteOrg / lute-v3

LUTE = Learning Using Texts: learn languages through reading. Python/Flask.
MIT License
415 stars 45 forks source link

Change audio file #467

Open jamesdeluk opened 1 month ago

jamesdeluk commented 1 month ago

Is your feature request related to a problem? Please describe.

Be able to change the audio file after a book has been created.

Describe the solution you'd like

For example, under the Edit side menu, a "Change audio" option.

Describe alternatives you've considered

Changing the audio file directly in the storage, but this can alter the audio player tracking bar (i.e. if you replace a 2min audio clip with a 1min clip, and click 1m30s, it fails - you have to reload the page).

Additional context

If the duration was recalculated based on the audio file found, this could be a workaround.

jzohrab commented 1 month ago

Thanks @jamesdeluk - I didn't include it initially because

But yes, this should be added. If you have a different idea for handling the audio bookmarks, let me know -- the only other option I can think of is to leave them all as-is and have the user fix them, but that could be tedious too.

jamesdeluk commented 1 month ago

I don't typically use bookmarks, so I hadn't considered that.

I feel that if a user is replacing the audio they should realise bookmarks may not auto-sync, so I feel a warning would suffice?