Error color readability

[doubledup]

I've found the ErrorMsg and Error colors hard to read with the light foreground (editor_fg):

ErrorMsg

Error

Switching to the background color (editor_bg) looks easier to read:

ErrorMsg

Error

Before opening a PR, I want to check some things:

1. Do you think that the error colors should change to something other than editor_fg?
2. If so, should they change to use the editor_bg or a different color? ie. for ErrorMsg and Error, use common_error with editor_bg instead of with editor_fg.
3. ErrorMsg uses common_error as the foreground, but Error uses common_error as the background. Should we change one of them to match the other? If so, which one?

[doubledup]

My take:

1. The error colors should switch from editor_fg as that's hard to read with the common_error red.
2. editor_bg is a fine choice, though maybe there's a better one that will distinguish the error from the rest of the interface more clearly.
3. The editor_bg samples for ErrorMsg above look better than the Error samples to me. I'd prefer red text to a red background.

[doubledup]

Also thank you so much for maintaining this! Ayu stopped my colorscheme hopping years ago and I've used it everywhere every day since.

[Luxed]

I've had the same thought when I started using the theme a long time ago.
However, I get errors so rarely that it never bothered me enough to take the time to fix it.

I like your proposition. If I understand correctly, this is what you would do, right?

• Error: common_error background, editor_bg foreground
• ErrorMsg: no background, common_error foreground

This is what it would look like with Fugitive (Error) and a command line error (ErrorMsg):

I think we can have them both just be a foreground, like this:

The last one looks cleaner. It doesn't "pop out" as much, but I think it's okay. You can go with that!

[doubledup]

I meant to suggest common_error foreground and editor_bg background for both Error and ErrorMsg, which is the second suggestion. PR opened!