search

LycheeOrg / Lychee

A great looking and easy-to-use photo-management-system you can run on your server, to manage and share photos.
https://lycheeorg.github.io/
MIT License
3.41k stars 301 forks source link

Feature: Add tags for Albums #42

Open chrobs opened 5 years ago

chrobs commented 5 years ago

I thought about extending the Tags Feature such that albums may have tags as well. Then, you could add a parameter or selector for the lychee frame page such that not only the starred photos may be shown but the user can choose to show either starred ones or based on the photos'/albums' tags.

Motivation is, that the selected photos to be shown in the digital frame may vary, depending on mood or think of multiple frames for different family members accessing the same lychee instance.

elvisef commented 3 years ago

I thought about extending the Tags Feature such that albums may have tags as well.

I was just search for this, nothing found. And now I see someone wrote about this already : ) I wanted to add tags to albums, so they could be displayed in smart albums. I have, let's say about 1000 pictures ? So... I will need to make an SQL query to update all desired pics with certain tags. Alright, but what about if I add a new album with... 20, 30, 50 pics ? All pictures, one by one, click by click, adding tags ? Not really... this is why albums tags are a must I think ;/

2021-02-15_08-13

What are news on this feature ? Will this be applied soon ? Would be a nice feature, for me it's crucial. I have pics sorted to: sold, unsold, and so on... but they're in certain albums - one album = one item (with 1 >= pics).

ildyria commented 3 years ago

20, 30, 50 pics ? All pictures, one by one, click by click, adding tags ?

you know that CTRL + A works to select all pictures in an album or all sub-albums if there are no pictures. :)

MikeTheTux commented 2 years ago

I stumbled upon this issue, when having a similar request. My use case is the following:

I guess even the search should be improved: Search for Text vs. Tags, Albums vs. Pictures, ...

nagmat84 commented 2 years ago

This is a rather old issue and @ildyria proposed another solution for the original problem in his comment on Feb 15th 2021. However, @MikeTheTux requested the same thing some minutes ago. Hence, I would like to understand what use case shall be solved by this.

Please note, that I consider adding tags to albums only as a mechanism and one possible solution to solve a problem. May be there are other solutions for the problem, too. However, the actual problem has not been stated yet. So, I would like to ask you to go back one step and explain what problem shall be solved.

Moreover, I would like to elaborate that adding tags to album and showing tag albums inside tag albums isn't trivial at all. At the moment, Lychee is built around the paradigm that albums are a forest from the perspective of graph theory. In particular, each album has a definitive parent album (or is a top-level album). In particular, access control, ownership of albums, etc. is inherited from parent albums. Also, if one deletes an album all sub-albums are deleted, too, recursively. Just for the sake of discussion, let's assume that we had something like that and we have two albums A and B which both are tagged by foo and are supposed to include the tag foo, i.e. they point to each other. This means we might end up with arbitrary graph structures which may contain all sort of nasty things like loops, etc. This immediately leads to a lot of follow-up questions which must be thoroughly discussed and solved first. For example, if one of the albums is public and the other not and both "inherit" visibility from their "parent" which one wins? What album is displayed on the "root" level as a starting point if there isn't a definitive "root" album anymore? All albums? Anyway, these questions shall simply be some examples to illustrate how problematic this approach may get.

Back again to my initial question: What is the use case you wish to solve?

nagmat84 commented 2 years ago

My use case is the following:

  • I've hundreds of outdoor activity albums
  • I would like to to tag them with the kind of activity (skiing, mountaineering, ...)
  • Later I would like to search for all Albums (not Pictures) of the same kind

As @ildyria already said, you can use Ctrl + A to mark all photos in an album and then assign tags to photos in a batch.

I guess even the search should be improved: Search for Text vs. Tags, Albums vs. Pictures, ...

I agree with you but this is a completely different problem. Yes, the search could be improved a lot by some kind of "query language" which also allows to express things like title ~ "skiing" AND taken-before:2019-01-15. I agree that would be awesome.

MikeTheTux commented 2 years ago

As @ildyria already said, you can use Ctrl + A to mark all photos in an album and then assign tags to photos in a batch.

When doing like this, the Tag will be added to the Photo but not to the Album. If I then search for the Tag, I find as an example 1.000 (unsorted) Photos (=20 Albums with 50 Photos).

But the expected result of my search should be the 20 Albums only: grafik If I would like to see the pictures, I will open them one by one.

Does this help to understand my usecase?

It is just about finding some specific Albums via search in a huge list of Albums.

Until now I do not have a need for smart Albums or I haven't yet figured out who they could help me.