search

LyndonArmitage / HTML5PokemonSaveReader

A web application made using JavaScript and HTML5 that can be used to view the contents of Pokemon save files. Makes use of the HTML5 File API
15 stars 4 forks source link

Consider improvements mentioned in reddit comments #3

Open LyndonArmitage opened 9 years ago

LyndonArmitage commented 9 years ago

Have a look at the old Reddit comments from when I posted this there and consider the improvements.

Specifically this comment by /u/notonlythat:

You should move your maps (charMap, itemMap etc) outside of those functions or they get initialized every time your function is called.

http://jsperf.com/map-inside-vs-outside-of-function

Other than that your code looks good. A save file for testing would be great.

danimesq commented 8 years ago

@LyndonArmitage Code Update 2015? We are on 2016.