Lythom / capsule

A minecraft mod : Bring your base! Capsules can capture a region containing any blocks or machines, then deploy and undeploy at will. Inspired by Dragon Ball capsules.
MIT License
16 stars 13 forks source link

Immersive Engineering Waterwheel Blueprint requires too much Waterwheels #30

Closed DanteyPL closed 3 years ago

DanteyPL commented 3 years ago

Problem

After creation of blueprint with IE Kinetic Dynamo and 3 IE Waterwheels, blueprint requires 63 IE Waterwheels instead of 3 Waterwheels.

Expected Behavior

Blueprint requires 3 IE Waterwheels

Actual Behavior

Blueprint requires 63 IE Waterwheels

Steps to Reproduce the Problem

  1. Build structure with IE Kinetic Dynamo and 3 IE Waterwheels
  2. Create Capsule with that structure
  3. Create Blueprint Capsule
  4. Left Click capsule list 63 missing IE Waterwheels instead 3

Specifications

NukerNoah commented 3 years ago

Experienced this about mid-June in a creative world. Actually attempting to place a blueprint with IE Water Wheels has some interesting results. The kind of result that makes you say "Yep, that sure is 63 waterwheels." 2020-06-18_12 11 29 Capsule used to make the blueprint on the left. Result of using the blueprint capsule on the right.

Best guess, it is placing a water wheel in every block the waterwheel occupies. Not just the center one as would be proper. Likely confused by the water wheel having full collision in multiple blocks.

Lythom commented 3 years ago

Thanks for reporting ! Will look into this issue after the 1.15.2 port is ready and fix it for both 1.12 and 1.15 👍

Lythom commented 3 years ago

This was an issue with the default whitelist_blueprint configuration. I fixed the bug in the default release (to be published soon). This is something you can already fix in your pack without updating the mod by changing de config/capsule/blueprint_whitelist.json file by replacing

{
    "block": "immersiveengineering:wooden_device1",
    "keepNBT": {
      "dummy": null,
      "facing": null,
      "orientation": null,
      "rotation": null
    }
  },

by

{
    "block": "immersiveengineering:wooden_device1",
    "keepNBT": {
      "dummy": null,
      "facing": null,
      "orientation": null,
      "rotation": null,
      "offset": null,
      "prevRotation": null
    }
  },

Adding this for people searching information on the topic in the futur: I also took the opportunity to improve the documentation on blueprint whitelists (https://github.com/Lythom/capsule/wiki/Modpack-making#whitelist) by adding a video explaining how I fixed the bug to help any packmaker configuring new tile entities blocks to be handled by capsule (https://www.youtube.com/watch?v=6MpXay8rGFw).

Thanks again @NukerNoah for your help improving capsule!