search

M-Reimer / undoclosetab

Undo Close Tab Add-on for Firefox
GNU General Public License v3.0
90 stars 16 forks source link

Empty closed tabs list sometimes #117

Open Wronschien opened 2 years ago

Wronschien commented 2 years ago

Hello, I've been using this extension for a few years now (thank you by the way !) and I've come across a problem since a couple of weeks.

Sometimes the drop-down list of closed tabs gets empty. I can still undo close with keyboard shortcut though, and probably toolbar button. I mostly use the keyboard so I can't remember if the button still works, I should remember to try next time.

The method I found to get the list back is to unclose a number of tabs and then the list reappears. It may reach about 10-15 tabs to unclose before this works, sometimes less or even more. When I close again all these tabs the list remains. Today it happened 2 or 3 times.

I suppose it's linked to a recent firefox update, as the extension itself was last updated in march.

M-Reimer commented 2 years ago

I've seen this, too. In some situations, for some reason, the "closed tabs" don't have a "title" attribute. I'm currently unsure if that's an issue in my code that can be triggered somehow or if this is an API issue inside Firefox. In both cases it should be possible to workaround this issue as soon as I managed to reproduce it easily (which shouldn't be too difficult actually).

Wronschien commented 2 years ago

Great, I hope you'll manage to fix that.

M-Reimer commented 2 years ago

I tried really hard and if I want to force the error to happen, it does not work.

If you see it again, please restore one tab after another and always check if the list reappears. As soon as the list reappears, please tell me the last URL you restored.

Wronschien commented 2 years ago

Alright, I'll do that, thank you

Wronschien commented 2 years ago

Well it's just happened again, the last url is : http://redump.org/disc/72011/

M-Reimer commented 2 years ago

Didn't help... I can verify that the issue exists because I had it myself. But no matter what I try, I can not reproduce it now.

So if someone manages to find a step by step process which triggers this issue, then please add a comment here. I guess it may involve session restore. Meaning that it may be needed to close and reopen Firefox to trigger the issue.

Wronschien commented 2 years ago

I have some update, I wanted to reopen a tab I just closed and it wasn't in the list. Smelling something fishy I then closed the list and opened it again right away, it was empty this time ! After the now usual method to get it back, the tab I wanted that wasn't listed the first time is : https://www.cheathappens.com/show_board2.asp?headID=118546&titleID=19755&onPage=2

Maybe that could help you ?

Wronschien commented 1 year ago

Another update : it appears to be caused by some downloads. I mean, some files open a new tab before downloading, and it generally closes right away. And some of them seem to provoke the bug. I've recently downloaded a couple files with this behaviour, and both times the list became empty until I reverted back to these downloads. I don't know if this was clear enough ? Only a little number of downloads lead to this bug, fortunately. It would be quite irritating otherwise.

M-Reimer commented 1 year ago

Interesting but I would need some step by step instructions (including a public download link that triggers this) to reproduce.

Wronschien commented 1 year ago

Here is one It's the attachment "filter.zip", for the problem to occur you have to middle-click it, not normal left-click, that's something I have a habit to do to keep current tab. When downloaded (it's really a tiny file), open the closed tabs list once and it works, then right away a second time and now it's empty. As the offending tab is the first closed one, you just have to undo close once and the list reappears for good.

M-Reimer commented 1 year ago

Thanks for the testcase. I'll check that as soon as possible. In the end it is a bug in Firefox and all I can do here (again) is working it around and create a new bug report for Mozilla.

Wronschien commented 1 year ago

Yes, I supposed it was caused by an update of Firefox. Alright then, I hope that with these new elements, including the deeper research made by alexolog on another issue, you'll find a workaround.

M-Reimer commented 1 year ago

This is exactly what I expected. For some reason such tabs end with the "title" property undefined. I can catch this case and just ignore such tabs which will fix this issue. But it is a Firefox bug nonetheless.

Wronschien commented 1 year ago

Great news ! So this will be eventually fixed after quite a while, well it wasn't critical of course. And these quite useless tabs won't clutter the list anymore then, right ?

M-Reimer commented 1 year ago

I'll keep this open for now as I don't have a better place to keep track of upstream bugs. This should be reported upstream. Let's see if I find the time to do it.