M66B / XPrivacy

XPrivacy - The ultimate, yet easy to use, privacy manager
http://forum.xda-developers.com/xposed/modules/xprivacy-ultimate-android-privacy-app-t2320783
GNU General Public License v3.0
2.08k stars 527 forks source link

Slowly rebooting bug occurs again! #92

Closed 28Black closed 11 years ago

28Black commented 11 years ago

Hi Marcel,

Do you remember the problem? I have even previously sent you a logcat. Anyway, the problem was gone when I had completely reinstalled XPrivacy and had set it up again from scratch.

Since this morning, the problem occurs in the known circumference again. The reboot process takes now up to 10 minutes!!

If I freeze Xprivacy, the problem is gone.

Recently, I have not taken any new restrictions, the problem came almost overnight, and all by itself!

Any ideas? I still do not seem to be the only one with the problem!

M66B commented 11 years ago

Same as this https://github.com/M66B/XPrivacy/issues/59#issuecomment-19858443 ?

28Black commented 11 years ago

Yes :(

M66B commented 11 years ago

Did you check super user?

28Black commented 11 years ago

Yes, theres no problem, its granted till my smartphone starts ;)

M66B commented 11 years ago

Then please paste a link here to a captured logcat.

portamento commented 11 years ago

Here the same problem with rebooting lag (10-15 minutes in my case!!!). I'm going to read about how to obtain a logcat to send it to you.

28Black commented 11 years ago

Today I had to reboot my phone twice... holy cow its so damn annoying to wait ...and wait....and wait... Sorry, atm I did not get the chance to record a logcat at a PC.

But I am seriously considering to uninstall after XPrivacy again :( That would be really, really Too bad!

M66B commented 11 years ago

Please attach a link to a logcat to this issue.

28Black commented 11 years ago

Sorry, atm I did not get the chance to record a logcat at a PC. I hope portamento can do this :/ but have my old logcat... ;)

portamento commented 11 years ago

Hi Marcel. I just sent you a PM on XDA with a link to the logcat obtained during the last reboot of my device. Please, let me know if it's OK.

M66B commented 11 years ago

@portamento there is a lot of text in the logcat and I don't see apparent problems, except maybe that your device seems to have limited memory available.

portamento commented 11 years ago

But if I disable XPrivacy on Xposed, rebooting process ends in a few seconds, so it doesn't seem to be a memory issue.

P. S. Thanks to have taken the trouble to check such a huge logcat.

28Black commented 11 years ago

Yes same here, disabling XPrivacy solves the problem immediately. So it must be a problem caused by XPrivacy!!!

Maybe it's caused by the restriction of booting apps?...

M66B commented 11 years ago

@28Black: most probably this is caused by restrictions set in expert mode.

Make a backup of XPrivacy, clear all settings of XPrivacy as described in the FAQ and reboot to see if any restriction is causing this. If your paranoid level is high, disable internet beforehand.

If a restriction is causing this, try to figure out which one and if you found out which one, please document it in the wiki. http://wiki.faircode.eu/index.php?title=XPrivacy

28Black commented 11 years ago

"If a restriction is causing this, try to figure out which one"

28Black commented 11 years ago

btw: Expert Mode was not enabled ;)

28Black commented 11 years ago

Do I get the Pro Version when I find the bug? :D Then I'll spend my time in investigating :dancer:

M66B commented 11 years ago

All contributors can get the pro version without donating.

28Black commented 11 years ago

Hooah! So I'm working! (Anyway I'm considering a donation for your awesome work :+1: )

M66B commented 11 years ago

Can you please tell for the benefit of others what was the problem? Maybe document what not to do in the wiki: http://wiki.faircode.eu/index.php?title=XPrivacy

28Black commented 11 years ago

You have misunderstood me! I wanted to say that I'm working on it, to be a contributor. :D

However, I have finally found the error at 3 o'clock in the last night.

The cause is, as I suspected, the boot restriction. If one sets the hook, for an app that automatically starts (indicated by the warning triangle) then the next system boot-up takes extremely long time! If you remove the checkmarks for these apps, the next boot process is fast like it should be! :)

M66B commented 11 years ago

Are you using the latest version?

28Black commented 11 years ago

Yes

28Black commented 11 years ago

It occurs in every version so far;)

M66B commented 11 years ago

Then it must be specific apps being restricted, since I don't have this problem.

28Black commented 11 years ago

I can tell you which apps are affected....

28Black commented 11 years ago

Each app I've tested individually. Each is causing the slow boot-up.

Deselect any of these apps or freeze Xprivacy solves the problem immediately;)

28Black commented 11 years ago

So maybe you can check your code for the "boot" restriction ;)

M66B commented 11 years ago

I already did, but it is very simple: https://github.com/M66B/XPrivacy/blob/master/src/biz/bokhorst/xprivacy/XActivityThread.java#L53

M66B commented 11 years ago

My best guess is that your device has not enough memory for what you are doing and that XPrivacy uses a little memory more, resulting in this problem.

28Black commented 11 years ago

I'm using a Samsung Galaxy S3 , so I dont think I'm running out of memory ;)

An idea from me: Can you send me a "special" version, which logs exactly what and when your boat restriction is doing sth? Then I'll boot normally and send you the result. After that I'll restrict one of the apps above and reboot again. I'll also send you this result. Then you can see exactly where the error lies, right?

M66B commented 11 years ago

All versions write in the logcat, try the command:

logcat | grep XPrivacy

28Black commented 11 years ago

Sorry, atm I did not get the chance to record a logcat at a PC

M66B commented 11 years ago

Looking into it again

M66B commented 11 years ago

I have added some cleanup code, could you please try if it helps:

http://www.faircode.eu/xprivacy/XPrivacy_0.40.1.apk

M66B commented 11 years ago

Better use the today released version 0.41, it has the same cleanup code.

28Black commented 11 years ago

Tested it with half of the listed Apps now,... it seems to be fixed now!!! :] Great work :) Can you maybe explain me how you're cleanup code does its magic? :)

Thanks again for your great help! :)

M66B commented 11 years ago

https://github.com/M66B/XPrivacy/blob/master/src/biz/bokhorst/xprivacy/XActivityThread.java#L121

Tungstwenty commented 11 years ago

When linking to changed code, I would suggest using an URL bound to a specific commit instead of the master, as the link would be pointing to the wrong place in the future. Something like: https://github.com/M66B/XPrivacy/blob/8504ad05b5ac0cf100760aabb973904c0b89aa8e/src/biz/bokhorst/xprivacy/XActivityThread.java#L121